This repository was archived by the owner on Aug 7, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
chore: fix titles #599
Merged
Merged
chore: fix titles #599
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -209,14 +209,14 @@ function sidebarHome() { | |||||
| text: "Technical Specifications", | ||||||
| collapsed: true, | ||||||
| items: [ | ||||||
| { text: "overview", link: "/learn/specs/overview" }, | ||||||
| { text: "block-manager", link: "/learn/specs/block-manager" }, | ||||||
| { text: "block-validity", link: "/learn/specs/block-validity" }, | ||||||
| { text: "da", link: "/learn/specs/da" }, | ||||||
| { text: "full_node", link: "/learn/specs/full_node" }, | ||||||
| { text: "header-sync", link: "/learn/specs/header-sync" }, | ||||||
| { text: "p2p", link: "/learn/specs/p2p" }, | ||||||
| { text: "store", link: "/learn/specs/store" }, | ||||||
| { text: "Overview", link: "/learn/specs/overview" }, | ||||||
| { text: "Block Manager", link: "/learn/specs/block-manager" }, | ||||||
| { text: "Block Validity", link: "/learn/specs/block-validity" }, | ||||||
| { text: "Data Availability", link: "/learn/specs/da" }, | ||||||
| { text: "Full Node", link: "/learn/specs/full_node" }, | ||||||
| { text: "Header Sync", link: "/learn/specs/header-sync" }, | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The title "Header Sync" doesn't fully represent the content of the linked document. The file
Suggested change
|
||||||
| { text: "P2P", link: "/learn/specs/p2p" }, | ||||||
| { text: "Store", link: "/learn/specs/store" }, | ||||||
| ], | ||||||
| }, | ||||||
| ], | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new title "Block Validity" is less precise than the title of the document it links to. The file
learn/specs/block-validity.mdis titled "# Block and Header Validity" and covers both topics. To maintain consistency and avoid confusion, it's best to use the full title from the document.