fix(images): fix mirrors and versions and pin cmake version
#108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated rootfs and kernel artifacts don't seem to work with the actual firecracker configuration. Generate them leveraging different mirrors and using an aws different version. Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com> Co-Authored-By: irozzo-1A <iacopo@sysdig.com>
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com> Co-Authored-By: irozzo-1A <iacopo@sysdig.com>
Contextually, replace `rootfs` base image with `ubuntu:22.04`. Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com> Co-Authored-By: irozzo-1A <iacopo@sysdig.com>
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com> Co-Authored-By: irozzo-1A <iacopo@sysdig.com>
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com> Co-Authored-By: irozzo-1A <iacopo@sysdig.com>
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com> Co-Authored-By: irozzo-1A <iacopo@sysdig.com>
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com> Co-Authored-By: irozzo-1A <iacopo@sysdig.com>
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com> Co-Authored-By: irozzo-1A <iacopo@sysdig.com>
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com> Co-Authored-By: irozzo-1A <iacopo@sysdig.com>
Contextually, replace `rootfs` base image with `ubuntu:22.04`. Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com> Co-Authored-By: irozzo-1A <iacopo@sysdig.com>
The source directory works only for the current shell, and `gcc-9` is never used in that RUN step after activation, so remove the directive. Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com> Co-Authored-By: irozzo-1A <iacopo@sysdig.com>
In order to be sure that shell instructions in RUN steps run as intended, replace the default shell at build time with bash, enabling some safety options (`-euo pipefail`). At the moment, this is done only on rootfs images and builders. Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com> Co-Authored-By: irozzo-1A <iacopo@sysdig.com>
Install the same `cmake` version in rootfs and builder (`builder` and `modernprobe-builder` images. The `cmake` version to be installed is passed to Dockerfiles through build-args, and is kept in a separate `images/CMAKE_VERSION` file. User can override it at build time using `make CMAKE_VERSION=...`. Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com> Co-Authored-By: irozzo-1A <iacopo@sysdig.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, therealbobo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/hold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes broken mirrors and replace unavailable versions for linux headers, linux tools and kernel modules/sources. Moreover, it pins the installed
cmakeversion to version3.24.4, that is the current minimum supported version by libs.Thank you to @irozzo-1A for the big support.