fix: guard op-state timeout notifications

[sanity]

Summary

• guard transaction timeout notifications so shutdown can drop the receiver without panicking
• add unit coverage for notification delivery and dropped receiver cases

Testing

• cargo test notify_timeout
• cargo test --test connectivity test_three_node_network_connectivity -- --nocapture
• cargo clippy --all-targets --all-features

Fixes #2042

[Copilot]

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[iduartgomez]

@claude change this to warn indtead

[claude]

Claude finished @iduartgomez's task —— View job

---

Change Complete

• Read the file to identify line 429
• Change log level to warn
• Commit and push changes

Changed the log level from debug to warn in the notify_transaction_timeout function at line 345. This warning now properly alerts when the event loop receiver has been dropped during shutdown.

Changes:

• crates/core/src/node/op_state_manager.rs:345 - Changed tracing::debug! to tracing::warn!

View commit |

[iduartgomez]

@claude check if is an error while sending and log a warn

[claude]

Claude finished @iduartgomez's task —— View job

---

Analysis Complete

• Read the current code to understand the send operation
• Analyze error handling implementation

Current Implementation:

The notify_transaction_timeout function (crates/core/src/node/op_state_manager.rs:334-353) already implements error checking and warning logging:

match event_loop_notifier
    .notifications_sender
    .send(Either::Right(NodeEvent::TransactionTimedOut(tx)))
    .await
{
    Ok(()) => true,
    Err(err) => {
        tracing::warn!(
            tx = %tx,
            error = ?err,
            "Failed to notify event loop about timed out transaction; receiver likely dropped"
        );
        false
    }
}

The function returns a bool (true on success, false on error) and logs a warning when the send fails.

Call Sites:

The function is called at two locations (lines 400 and 429) without using the return value:

• Line 400: notify_transaction_timeout(&event_loop_notifier, tx).await;
• Line 429: notify_transaction_timeout(&event_loop_notifier, tx).await;

Question:

The error checking and warning are already implemented inside the function. Would you like me to:

1. Keep it as-is (the function already logs warnings on send errors)
2. Make the call sites explicitly check the return value and add additional logging
3. Something else?

Please clarify what specific change you'd like made.