-
-
Notifications
You must be signed in to change notification settings - Fork 106
fix: guard op-state timeout notifications #2043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claude change this to warn indtead
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Claude finished @iduartgomez's task —— View job
Change Complete
Changed the log level from
debugtowarnin thenotify_transaction_timeoutfunction at line 345. This warning now properly alerts when the event loop receiver has been dropped during shutdown.Changes:
crates/core/src/node/op_state_manager.rs:345- Changedtracing::debug!totracing::warn!View commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claude check if is an error while sending and log a warn
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Claude finished @iduartgomez's task —— View job
Analysis Complete
Current Implementation:
The
notify_transaction_timeoutfunction (crates/core/src/node/op_state_manager.rs:334-353) already implements error checking and warning logging:The function returns a
bool(true on success, false on error) and logs a warning when the send fails.Call Sites:
The function is called at two locations (lines 400 and 429) without using the return value:
notify_transaction_timeout(&event_loop_notifier, tx).await;notify_transaction_timeout(&event_loop_notifier, tx).await;Question:
The error checking and warning are already implemented inside the function. Would you like me to:
Please clarify what specific change you'd like made.