fix: sqlite always not work and another things #613

Decodetalkers · 2025-01-19T00:55:03Z

this is a huge pr.. before I think this project won't maintain anymore so I work myself, and follow another fork.. but that one also inactive

I will pr for this

This pr induced typos ci, dependabot, bump a lot of dependencies, make format, remove deperate function and etc

I think the most important part of this pr is:

bump the version of exposed, which solved the problem of it will through error during save the dependencies, which made kls throw all dependencies, cause the editer been whole red.

Then it induced some other ci, like dependencies bot, and some style change, during the time that I am maintaining it.

Also induced some changes for the log which I think been good to my debugging. I love that change because I can see the logs when debugging it. it is quite difficult for me to get the lsplog in neovim, so I found a way to keep the log to stderr. And I made the log can do the things like tracing in rust

Decodetalkers · 2025-01-19T01:10:46Z

@fwcd Can you take a look? I think I have fixed many thing.. and also induced some features, when I am debugging... because this days I have maintain another fork.. for if this one won't active

Decodetalkers · 2025-01-19T01:12:06Z

server/src/main/kotlin/org/javacs/kt/Main.kt

    } ?: Pair(System.`in`, System.out)

-    val server = KotlinLanguageServer()
+    if (args.fullLog) {


this will enable something like tracing, when I am debug, I think it is useful, so ..

Decodetalkers · 2025-01-19T01:12:51Z

server/src/main/kotlin/org/javacs/kt/Main.kt

    @Parameter(names = ["--tcpClientHost", "-h"])
    var tcpClientHost: String = "localhost"
+
+    @Parameter(names = ["--tcpDebug"])


if open tcpDebug, the log will always on stderr, then it won't be redirected lsplog

Decodetalkers · 2025-01-19T01:13:24Z

server/src/main/kotlin/org/javacs/kt/SourcePath.kt

            sourceFile(uri).prepareCompiledFile()

+    // Compile changed files
+    private fun compileAndUpdate(changed: List<SourceFile>, kind: CompilationKind): BindingContext? {


I think it is not good to put a function inside another function, so I split it

Decodetalkers · 2025-01-19T01:13:55Z

server/src/main/kotlin/org/javacs/kt/SourcePath.kt

        // Combine with past compilations
-        val same = sources - allChanged
-        val combined = listOf(buildScriptsContext, sourcesContext).filterNotNull() + same.map { it.compiledContext!! }
+        val same = sources - allChanged.toSet()


it is changed under the help of idea.. yes , many changes are by idea

Decodetalkers · 2025-01-19T01:14:36Z

server/src/main/kotlin/org/javacs/kt/codeaction/quickfix/ImplementAbstractMembersQuickFix.kt

            val superClassTypeArguments = getSuperClassTypeProjections(file, it)
            classDescriptor.getMemberScope(superClassTypeArguments).getContributedDescriptors().filter { classMember ->
-               (classMember is FunctionDescriptor && classMember.modality == Modality.ABSTRACT && !overridesDeclaration(kotlinClass, classMember)) || (classMember is PropertyDescriptor && classMember.modality == Modality.ABSTRACT && !overridesDeclaration(kotlinClass, classMember))
+                (classMember is FunctionDescriptor && classMember.modality == Modality.ABSTRACT && !overridesDeclaration(


idea thought this will be better

Decodetalkers · 2025-01-19T01:14:52Z

server/src/main/kotlin/org/javacs/kt/compiler/Compiler.kt


 private val GRADLE_DSL_DEPENDENCY_PATTERN = Regex("^gradle-(?:kotlin-dsl|core).*\\.jar$")

+private val ResolveImportList = listOf(


too long, so I split it

Decodetalkers · 2025-01-19T01:15:08Z

server/src/main/kotlin/org/javacs/kt/compiler/Compiler.kt

            configuration = KotlinCompilerConfiguration().apply {
                val langFeatures = mutableMapOf<LanguageFeature, LanguageFeature.State>()
-                for (langFeature in LanguageFeature.values()) {
+                for (langFeature in LanguageFeature.entries) {


the lint by idea

I need to fix the db problem.. ..but how..

Decodetalkers · 2025-01-19T01:36:19Z

Please split this up into smaller PRs, each addressing a single concern. A huge kitchen-sink PR that includes a bunch of minor style changes is something I'll be unlikely to merge

done, it seems been many commit here..

fwcd · 2025-01-19T01:55:39Z

Small commits are good, but please also group them into separate PRs. What I had in mind was a bunch of small PRs along the lines of:

"Update Detekt configuration and baseline" -> only updates the Detekt XMLs
"Bump dependencies" -> only updates libs.versions.toml and perhaps a few build scripts
"Add --tcpDebug option" -> only adds the new flag etc.
... etc ...

Decodetalkers · 2025-01-19T01:59:47Z

Small commits are good, but please also group them into separate PRs. What I had in mind was a bunch of small PRs along the lines of:
* "Update Detekt configuration and baseline" -> only updates the Detekt XMLs

* "Bump dependencies" -> only updates `libs.versions.toml` and perhaps a few build scripts

* "Add `--tcpDebug` option" -> only adds the new flag etc.

* ... etc ...

I have committed a lot during this time,.. and update deps also will change some code.. now they all mixing up. I feel it will be difficult to split them.. The big problem is that I induced the typos ci and made a huge change there

Detekt configure and baseline is mixed together with typos... and after I do some format detekt find more problem so then I edit the detekt... seems they are hard to split.. but may you please let me just split the cli feature one? I can make that in another pr..

Decodetalkers · 2025-01-19T02:08:55Z

Small commits are good, but please also group them into separate PRs. What I had in mind was a bunch of small PRs along the lines of:
* "Update Detekt configuration and baseline" -> only updates the Detekt XMLs

* "Bump dependencies" -> only updates `libs.versions.toml` and perhaps a few build scripts

* "Add `--tcpDebug` option" -> only adds the new flag etc.

* ... etc ...
I have committed a lot during this time,.. and update deps also will change some code.. now they all mixing up. I feel it will be difficult to split them.. The big problem is that I induced the typos ci and made a huge change there

Detekt configure and baseline is mixed together with typos... and after I do some format detekt find more problem so then I edit the detekt... seems they are hard to split.. but may you please let me just split the cli feature one? I can make that in another pr..

Then this pr just for bump the version of exposed, but also some changes in ci.. I will split the cli part, can this be accept?

Decodetalkers · 2025-01-19T02:39:27Z

ok.. I will put this pr here and open other pr instead, this will just be used as reference

Decodetalkers · 2025-01-19T03:19:36Z

@fwcd I have already split them into other prs, can you please take a look? after those been merged, I will continue to tidy up the code, and remove the deprecated part of hte use of exposed

Decodetalkers marked this pull request as draft January 19, 2025 00:55

Decodetalkers force-pushed the hugefix branch 8 times, most recently from f2fca1f to 644c09b Compare January 19, 2025 01:06

Decodetalkers marked this pull request as ready for review January 19, 2025 01:06

Decodetalkers force-pushed the hugefix branch 2 times, most recently from dd9bb6d to 3f58147 Compare January 19, 2025 01:10

Decodetalkers commented Jan 19, 2025

View reviewed changes

Decodetalkers added 12 commits January 19, 2025 10:32

chore: code tidyup and fixci

f01c235

fix: ci

98aa527

chore: do fmt

a6f04e2

chore: remove useless code

590bccb

feat: add fullLog param

6299389

feat: enable this feature

934243c

fix: the classname is not true

de016c7

fix: ci

f203e1d

chore: some tidy up

5b85dba

fix: the import cannot work well

a86e6a0

I need to fix the db problem.. ..but how..

chore: bump epose

8046bfc

fix: ci

b38df67

Decodetalkers force-pushed the hugefix branch from 71633bc to a4e3e84 Compare January 19, 2025 01:35

Decodetalkers force-pushed the hugefix branch 3 times, most recently from 096ff06 to 7ee67ac Compare January 19, 2025 01:43

Decodetalkers requested a review from fwcd January 19, 2025 01:49

Decodetalkers force-pushed the hugefix branch from 7ee67ac to 684890f Compare January 19, 2025 02:04

Decodetalkers force-pushed the hugefix branch from 684890f to 39975ef Compare January 19, 2025 02:10

chore: adjust for origin upstream

357822b

Decodetalkers force-pushed the hugefix branch 2 times, most recently from a2a48f6 to 357822b Compare January 19, 2025 02:37

Decodetalkers marked this pull request as draft January 19, 2025 03:03

Decodetalkers closed this Jan 19, 2025


		private val GRADLE_DSL_DEPENDENCY_PATTERN = Regex("^gradle-(?:kotlin-dsl\|core).*\\.jar$")

		private val ResolveImportList = listOf(

fix: sqlite always not work and another things #613

fix: sqlite always not work and another things #613

Conversation

Decodetalkers commented Jan 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Decodetalkers commented Jan 19, 2025

Uh oh!

Decodetalkers Jan 19, 2025

Choose a reason for hiding this comment

Uh oh!

Decodetalkers Jan 19, 2025

Choose a reason for hiding this comment

Uh oh!

Decodetalkers Jan 19, 2025

Choose a reason for hiding this comment

Uh oh!

Decodetalkers Jan 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Decodetalkers Jan 19, 2025

Choose a reason for hiding this comment

Uh oh!

Decodetalkers Jan 19, 2025

Choose a reason for hiding this comment

Uh oh!

Decodetalkers Jan 19, 2025

Choose a reason for hiding this comment

Uh oh!

Decodetalkers commented Jan 19, 2025

Uh oh!

fwcd commented Jan 19, 2025

Uh oh!

Decodetalkers commented Jan 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Decodetalkers commented Jan 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Decodetalkers commented Jan 19, 2025

Uh oh!

Decodetalkers commented Jan 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Decodetalkers commented Jan 19, 2025 •

edited

Loading

Decodetalkers Jan 19, 2025 •

edited

Loading

Decodetalkers commented Jan 19, 2025 •

edited

Loading

Decodetalkers commented Jan 19, 2025 •

edited

Loading