Skip to content

fix(dashboards-comparison): check aggregates and columns fields in case fields is empty #96474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nikkikapadia
Copy link
Member

There are a couple widget cases where there is nothing in fields array but have something in the aggregates and columns array. I've merged all of the lists to ensure we have all the fields in the widget.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 25, 2025
@nikkikapadia nikkikapadia marked this pull request as ready for review July 28, 2025 15:22
@nikkikapadia nikkikapadia requested a review from a team as a code owner July 28, 2025 15:22
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #96474      +/-   ##
==========================================
+ Coverage   84.08%   87.77%   +3.68%     
==========================================
  Files       10661    10656       -5     
  Lines      614983   614836     -147     
  Branches    24182    24149      -33     
==========================================
+ Hits       517121   539657   +22536     
+ Misses      97572    74889   -22683     
  Partials      290      290              

@nikkikapadia nikkikapadia merged commit d00396a into master Jul 28, 2025
64 checks passed
@nikkikapadia nikkikapadia deleted the nikki/fix/check-aggregates-for-dashbaords-comparison branch July 28, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants