Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/sentry/discover/compare_tables.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,21 @@ def compare_tables_for_dashboard_widget_queries(
"query": None,
}

fields = widget_query.fields
aggregates = widget_query.aggregates
columns = widget_query.columns
query_fields = widget_query.fields

fields_set = set()

if aggregates:
fields_set.update(aggregates)
if columns:
fields_set.update(columns)
if query_fields:
fields_set.update(query_fields)

fields = list(fields_set)

if len(fields) == 0:
with sentry_sdk.isolation_scope() as scope:
scope.set_tag("passed", False)
Expand Down
22 changes: 22 additions & 0 deletions tests/sentry/discover/test_compare_tables.py
Original file line number Diff line number Diff line change
Expand Up @@ -358,3 +358,25 @@ def test_compare_widget_query_with_no_metrics_data(self) -> None:

comparison_result = compare_tables_for_dashboard_widget_queries(widget_query)
assert comparison_result["passed"] is True

def test_compare_widget_query_with_no_fields(self) -> None:
widget = DashboardWidget.objects.create(
dashboard=self.dashboard,
title="Test No Fields Widget",
order=1,
display_type=DashboardWidgetDisplayTypes.TABLE,
widget_type=DashboardWidgetTypes.TRANSACTION_LIKE,
)

widget_query = DashboardWidgetQuery.objects.create(
widget=widget,
name="",
order=0,
conditions="",
aggregates=["count()"],
columns=[],
fields=[],
)

comparison_result = compare_tables_for_dashboard_widget_queries(widget_query)
assert comparison_result["passed"] is True
Loading