Add testsuites hook #96494
Add testsuites hook #96494
Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #96494 +/- ##
==========================================
- Coverage 84.06% 77.41% -6.65%
==========================================
Files 10653 10651 -2
Lines 614683 614645 -38
Branches 24161 24159 -2
==========================================
- Hits 516731 475854 -40877
- Misses 97662 138501 +40839
Partials 290 290 |
| PLACEHOLDER_TEST_SUITES.every(suite => value.includes(suite)); | ||
| // Show 2 suites only if the combined string's length does not exceed 22. | ||
| value.length === 0 || testSuites?.every(suite => value.includes(suite)); | ||
| // Show 2 suites only if the combined string's length does not exceed MAX_SUITE_UI_LENGTH. |
There was a problem hiding this comment.
nit: we say doesn't exceed, but on line 103 we use < rather than <=
There was a problem hiding this comment.
Techincalllyyyy, you are right haha, changing it
| @@ -50,9 +60,11 @@ export default function TestsPage() { | |||
| <BranchSelector /> | |||
| <DateSelector /> | |||
| </PageFilterBar> | |||
| <TestSuiteDropdown /> | |||
| {(branch === undefined || branch === null || branch === defaultBranch) && ( | |||
There was a problem hiding this comment.
these first 2 checks are for the case where we don't have anything populated?
If so, can we get away with !branch || branch === defaultBranch?
There was a problem hiding this comment.
They're for the most part the same, although your approach will evaluate an empty string differently, but I'm comfortable w/ pushing your suggestion. I tend to go for readability over verbosity, but I think this is a case where it's okay
There was a problem hiding this comment.
yep yep thats right, as well as the "false" or number 0, but Idk if those are valid branch values here anyway
| @@ -103,8 +118,9 @@ function Content() { | |||
|
|
|||
| return ( | |||
| <Fragment> | |||
| {/* TODO: Conditionally show these if the branch we're in is the main branch */} | |||
| <Summaries /> | |||
| {(selectedBranch === undefined || | |||
There was a problem hiding this comment.
Similar story here with !selectedBranch || selectedBranch === defaultBranch
This PR adds the test suite FE hook to fetch test suite related information.
Closes https://linear.app/getsentry/issue/CCMRG-1428/hideshow-summaries-based-on-branch-selection and https://linear.app/getsentry/issue/CCMRG-1426/ta-test-suite-dropdown
Notes
TestSuiteDropdowncomponentuseTestSuiteshookuseGetTestResultshook to further filter bytestSuitesif selecteduseInfinitedTestResultshook to it's parent component to leverage defaultBranch field - hook is only enabled when all orgId, repo, branch and date are selected, so this avoids unnecessary, preemptive callstestSuiteswhen repo + org are changed