-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Add testsuites hook #96494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+151
−50
Merged
Add testsuites hook #96494
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6fb5813
WIP: add testsuites gohook
adrianviquez 99411b8
feat: add logic to fetch test suites and have those affect the test r…
adrianviquez e03829e
address potentially undefined data
adrianviquez 8476ce7
fix undefined branch value
adrianviquez 5ea9199
address small PR comments
adrianviquez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
static/app/components/codecov/testSuiteDropdown/useTestSuites.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
import {useMemo} from 'react'; | ||
|
||
import {useCodecovContext} from 'sentry/components/codecov/context/codecovContext'; | ||
import type {QueryKeyEndpointOptions} from 'sentry/utils/queryClient'; | ||
import {useQuery} from 'sentry/utils/queryClient'; | ||
import useApi from 'sentry/utils/useApi'; | ||
import useOrganization from 'sentry/utils/useOrganization'; | ||
|
||
type TestSuite = { | ||
testSuites: string[]; | ||
}; | ||
|
||
type QueryKey = [url: string, endpointOptions: QueryKeyEndpointOptions]; | ||
|
||
export function useTestSuites() { | ||
const api = useApi(); | ||
const organization = useOrganization(); | ||
const {integratedOrgId, repository} = useCodecovContext(); | ||
|
||
const {data, ...rest} = useQuery<TestSuite, Error, TestSuite, QueryKey>({ | ||
queryKey: [ | ||
`/organizations/${organization.slug}/prevent/owner/${integratedOrgId}/repository/${repository}/test-suites/`, | ||
{query: {}}, | ||
], | ||
queryFn: async ({queryKey: [url]}): Promise<TestSuite> => { | ||
const result = await api.requestPromise(url, { | ||
method: 'GET', | ||
query: {}, | ||
}); | ||
|
||
return result as TestSuite; | ||
}, | ||
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
enabled: !!(integratedOrgId && repository), | ||
}); | ||
|
||
const memoizedData = useMemo(() => { | ||
return data?.testSuites || []; | ||
}, [data]); | ||
|
||
return { | ||
data: memoizedData, | ||
// TODO: only provide the values that we're interested in | ||
...rest, | ||
}; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we say doesn't exceed, but on line 103 we use < rather than <=
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Techincalllyyyy, you are right haha, changing it