-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
bug(stories): Clarify graph icon names #96495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
defaultProps: { | ||
type: 'area', | ||
}, | ||
}, | ||
{ | ||
id: 'graph-type-scatter', | ||
name: 'Graph', | ||
name: 'GraphScatter', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Graph Icon Naming Causes Component Lookup Errors
The name
property for graph icons (circle, bar, area, scatter) was changed from 'Graph' to specific variants (e.g., 'GraphCircle'). This causes component lookup failures because these icons share a single IconGraph
component, differentiated by type
props, but the new names cause lookups for non-existent IconGraphCircle
components. The line graph icon correctly retains the 'Graph' name.
Locations (1)
I believe Having the stories recommend We could also go all the way along and look at why is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rbro112
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Was working on some new UI and using stories, noticed the naming for the IconGraph was duplicated for all other graph icon types (
IconGraphCircle
,IconGraphBar
, etc).This correctly names each now.