Skip to content

bug(stories): Clarify graph icon names #96495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rbro112
Copy link
Member

@rbro112 rbro112 commented Jul 26, 2025

Was working on some new UI and using stories, noticed the naming for the IconGraph was duplicated for all other graph icon types (IconGraphCircle, IconGraphBar, etc).

Screenshot 2025-07-25 at 5 27 16 PM

This correctly names each now.

@rbro112 rbro112 requested a review from a team as a code owner July 26, 2025 00:25
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 26, 2025
Copy link
Member Author

rbro112 commented Jul 26, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rbro112 rbro112 changed the title Clarify graph icon names bug(stories): Clarify graph icon names Jul 26, 2025
defaultProps: {
type: 'area',
},
},
{
id: 'graph-type-scatter',
name: 'Graph',
name: 'GraphScatter',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Graph Icon Naming Causes Component Lookup Errors

The name property for graph icons (circle, bar, area, scatter) was changed from 'Graph' to specific variants (e.g., 'GraphCircle'). This causes component lookup failures because these icons share a single IconGraph component, differentiated by type props, but the new names cause lookups for non-existent IconGraphCircle components. The line graph icon correctly retains the 'Graph' name.

Locations (1)

Fix in CursorFix in Web

@ryan953
Copy link
Member

ryan953 commented Jul 26, 2025

I believe <IconGraph> refers to the file : https://github.com/getsentry/sentry/blob/master/static/app/icons/iconGraph.tsx#L12-L25
People can use <IconGraph type='bar' /> to make their bar chart.

Having the stories recommend <IconGraphBar /> directly is a fine change, but then we should remove the defaultProps: {type: "bar"} business in the stories too.

We could also go all the way along and look at why is <IconGraph /> even there at all, maybe just purge the whole site of <IconGraph/>

Copy link
Member

@JonasBa JonasBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rbro112

@getsantry
Copy link
Contributor

getsantry bot commented Aug 19, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants