Skip to content

bug(stories): Clarify graph icon names #96495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bug(stories): Clarify graph icon names #96495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions static/app/icons/icons.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,28 +1136,28 @@ const SECTIONS: TSection[] = [
},
{
id: 'graph-type-circle',
name: 'Graph',
name: 'GraphCircle',
defaultProps: {
type: 'circle',
},
},
{
id: 'graph-type-bar',
name: 'Graph',
name: 'GraphBar',
defaultProps: {
type: 'bar',
},
},
{
id: 'graph-type-area',
name: 'Graph',
name: 'GraphArea',
defaultProps: {
type: 'area',
},
},
{
id: 'graph-type-scatter',
name: 'Graph',
name: 'GraphScatter',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Graph Icon Naming Causes Component Lookup Errors

The name property for graph icons (circle, bar, area, scatter) was changed from 'Graph' to specific variants (e.g., 'GraphCircle'). This causes component lookup failures because these icons share a single IconGraph component, differentiated by type props, but the new names cause lookups for non-existent IconGraphCircle components. The line graph icon correctly retains the 'Graph' name.

Locations (1)

Fix in Cursor • Fix in Web

defaultProps: {
type: 'scatter',
},
Expand Down
Loading