fix(aci): Fix Workflow serializer lastTriggered #96688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #96688 +/- ##
==========================================
- Coverage 80.64% 80.63% -0.01%
==========================================
Files 8471 8472 +1
Lines 373107 373155 +48
Branches 24207 24207
==========================================
+ Hits 300880 300902 +22
- Misses 71892 71918 +26
Partials 335 335 |
|
@ameliahsu The is_single_written filtering is somehow less trivial than I assumed and isn't entirely related to this fix, so I'll send another PR for that soon. |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 4, 2025
We need to use `values()` to ensure we're not implicitly grouping by `workflowfirehistory.id` rather than `workflowfirehistory.workflow_id`. Updates tests to ensure undoing this will fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use
values()to ensure we're not implicitly grouping byworkflowfirehistory.idrather thanworkflowfirehistory.workflow_id.Updates tests to ensure undoing this will fail.