[fix] Fix get_organization_seer_consent_by_org_name to only obey UI toggles
#96725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
suejung-sentry
approved these changes
Jul 30, 2025
| @@ -229,18 +233,16 @@ def get_organization_seer_consent_by_org_name( | |||
| for org_integration in org_integrations: | |||
| try: | |||
| org = Organization.objects.get(id=org_integration.organization_id) | |||
| seer_org_acknowledgement = get_seer_org_acknowledgement(org_id=org.id) | |||
| github_extension_enabled = org.id in options.get("github-extension.enabled-orgs") | |||
There was a problem hiding this comment.
github_extension_enabled = org.id in options.get("github-extension.enabled-orgs")
Do you know what does github-extension.enabled-org mean ? Does that mean the user in the Sentry UI somewhere consented to use of the sentry.io github app or something? If so, do we need to preserve this check?
There was a problem hiding this comment.
That is copilot related, so we can ignore that.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 4, 2025
… toggles (#96725) <!-- Describe your PR here. --> The `get_organization_seer_consent_by_org_name` controls the consent flow for Prevent AI features via the seer-by-sentry GitHub app. We want the consent gated by 2 toggles only. The `Show Generative AI Features` toggle, and the `Enable PR review and test generation` toggle. We were using the `get_seer_org_acknowledgement` function before, but that is not required for this flow. <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_organization_seer_consent_by_org_namecontrols the consent flow for Prevent AI features via the seer-by-sentry GitHub app. We want the consent gated by 2 toggles only. TheShow Generative AI Featurestoggle, and theEnable PR review and test generationtoggle.We were using the
get_seer_org_acknowledgementfunction before, but that is not required for this flow.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.