Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Jan 12, 2026

@parthea parthea requested a review from a team as a code owner January 12, 2026 20:13
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 12, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the default Python version used for testing and linting within the Nox configuration. The change ensures that these automated processes leverage a more recent Python runtime, specifically targeting version 3.14, and standardizes the Python version used across relevant Nox sessions.

Highlights

  • Default Python Version Update: The DEFAULT_PYTHON_VERSION in noxfile.py has been updated from 3.8 to 3.14.
  • Nox Session Python Version Alignment: The lint and lint_setup_py Nox sessions now dynamically use the DEFAULT_PYTHON_VERSION variable instead of being hardcoded to 3.10.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (3)
    • .github/workflows/lint.yml
    • .github/workflows/mypy.yml
    • .github/workflows/unittest.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default Python version to 3.14 for various nox sessions. The changes correctly update the DEFAULT_PYTHON_VERSION constant and refactor the lint and lint_setup_py sessions to use this constant, which is a good improvement for maintainability. The changes look good, and I have one suggestion to improve consistency even further.

BLACK_PATHS = ["docs", "google", "tests", "noxfile.py", "setup.py"]

DEFAULT_PYTHON_VERSION = "3.8"
DEFAULT_PYTHON_VERSION = "3.14"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this DEFAULT_PYTHON_VERSION is now used by most nox sessions, the docs and docfx sessions are still hardcoded to use Python 3.10. For better maintainability and consistency, consider updating them to use this DEFAULT_PYTHON_VERSION constant as well, if their dependencies are compatible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is blocked on googleapis/sphinx-docfx-yaml#345.
Add comment in 6970ade

@parthea parthea merged commit 516511d into main Jan 12, 2026
19 checks passed
@parthea parthea deleted the update-default-python branch January 12, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants