Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: "3.10"
python-version: "3.14"
- name: Install nox
run: |
python -m pip install --upgrade setuptools pip wheel
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mypy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: "3.8"
python-version: "3.14"
- name: Install nox
run: |
python -m pip install --upgrade setuptools pip wheel
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unittest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: "3.8"
python-version: "3.14"
- name: Install coverage
run: |
python -m pip install --upgrade setuptools pip wheel
Expand Down
12 changes: 8 additions & 4 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@
BLACK_VERSION = "black==23.7.0"
BLACK_PATHS = ["docs", "google", "tests", "noxfile.py", "setup.py"]

DEFAULT_PYTHON_VERSION = "3.8"
DEFAULT_PYTHON_VERSION = "3.14"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this DEFAULT_PYTHON_VERSION is now used by most nox sessions, the docs and docfx sessions are still hardcoded to use Python 3.10. For better maintainability and consistency, consider updating them to use this DEFAULT_PYTHON_VERSION constant as well, if their dependencies are compatible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is blocked on googleapis/sphinx-docfx-yaml#345.
Add comment in 6970ade

CURRENT_DIRECTORY = os.path.abspath(os.path.dirname(__file__))

# Error if a python version is missing
nox.options.error_on_missing_interpreters = True


@nox.session(python="3.10")
@nox.session(python=DEFAULT_PYTHON_VERSION)
def lint(session):
"""Run linters.

Expand Down Expand Up @@ -102,11 +102,11 @@ def unit(session):
default(session)


@nox.session(python="3.10")
@nox.session(python=DEFAULT_PYTHON_VERSION)
def lint_setup_py(session):
"""Verify that setup.py is valid (including RST check)."""

session.install("docutils", "Pygments")
session.install("docutils", "Pygments", "setuptools")
session.run("python", "setup.py", "check", "--restructuredtext", "--strict")


Expand All @@ -122,6 +122,8 @@ def cover(session):
session.run("coverage", "erase")


# Keep docs session at Python 3.10 until
# https://github.com/googleapis/sphinx-docfx-yaml/issues/345 is fixed
@nox.session(python="3.10")
def docs(session):
"""Build the docs for this library."""
Expand Down Expand Up @@ -158,6 +160,8 @@ def docs(session):
)


# Keep docfx session at Python 3.10 until
# https://github.com/googleapis/sphinx-docfx-yaml/issues/345 is fixed
@nox.session(python="3.10")
def docfx(session):
"""Build the docfx yaml files for this library."""
Expand Down
10 changes: 3 additions & 7 deletions pytest.ini
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ filterwarnings =
# Remove once the minimum supported version of `google-api-core` is 2.15.0
ignore:.*pkg_resources.declare_namespace:DeprecationWarning
ignore:.*pkg_resources is deprecated as an API:DeprecationWarning
# Remove after support for Python 3.8 is dropped
ignore:You are using a non-supported Python version \(3\.8:DeprecationWarning
ignore:You are using a non-supported Python version \(3\.8:FutureWarning
# Remove after support for Python 3.9 is dropped
ignore:You are using a Python version \(3\.9:FutureWarning
# Remove after support for Python 3.10 is dropped
ignore:.*You are using a Python version \(3\.10:FutureWarning
# Remove after support for Python 3.8, 3.9 and/or 3.10+ is dropped
ignore:\s*You are using a (non-supported )?Python version \(?3\.(8|9|1[0-9]+):DeprecationWarning
ignore:\s*You are using a (non-supported )?Python version \(?3\.(8|9|1[0-9]+):FutureWarning
Loading