Add deploy command and more instruction for deploying a new service #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Launch the `master.yaml` from aws cli with command: | ||
| ``` | ||
| aws cloudformation create-stack --stack-name <your stack name> --template-body file://<absolute path to the local master.yaml> --capabilities CAPABILITY_NAMED_IAM --parameters ParameterKey=KeyPairName,ParameterValue=<Name of your AWS account's key pair> |
Collaborator
There was a problem hiding this comment.
What do we do to update CF with a new version of the master.yaml for an existing stack? Do we just substitute update-stack parameter for the create-stack parameter here?
| 1. Push your container to a registry somewhere (e.g., [Docker Hub](https://hub.docker.com/), [Amazon ECR](https://aws.amazon.com/ecr/)). | ||
| 2. Copy one of the existing service templates in [services/*](/services). | ||
| 3. Update the `ContainerName` and `Image` parameters to point to your container image instead of the example container. | ||
| 3. Update the `ContainerName` and `Image` parameters to point to your container image instead of the example container. Also make sure the `ContainerName` of property `LoadBalancers` of the ECS service matches with the `Name` in `ContainerDefinitions` property of `TaskDefinition`. |
Collaborator
There was a problem hiding this comment.
Is it also necessary to change the Image value (at least the final suffix) found under service.yaml > Resources > TaskDefinition > Properties > ContainerDefinitions ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to deploy a new service with the given instruction and succeed. The current instruction is confirmably correct but also need some more clarity and caution. This PR address these issues.
The reason for:
is because
aws cloudformation create-stackcommand doesn't accept local file for nested stack.yamlfile. User need to upload the.yamltemplate to S3 and paste the link tomaster.yaml