-
Notifications
You must be signed in to change notification settings - Fork 12
Add deploy command and more instruction for deploying a new service #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
khashf
wants to merge
1
commit into
hackoregon:master
Choose a base branch
from
khashf:readme-patch-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,7 +54,14 @@ After the CloudFormation templates have been deployed, the [stack outputs](http: | |
|
|
||
| ### How to Deploy | ||
|
|
||
| Stack is setup to launch stack in the us-west-2 (Oregon) region in your account: | ||
| Stack is setup to launch stack in the us-west-2 (Oregon) region in your account. | ||
|
|
||
| Launch the `master.yaml` from aws cli with command: | ||
| ``` | ||
| aws cloudformation create-stack --stack-name <your stack name> --template-body file://<absolute path to the local master.yaml> --capabilities CAPABILITY_NAMED_IAM --parameters ParameterKey=KeyPairName,ParameterValue=<Name of your AWS account's key pair> | ||
|
|
||
| ``` | ||
|
|
||
|
|
||
| ### Customize the templates | ||
|
|
||
|
|
@@ -68,9 +75,9 @@ Stack is setup to launch stack in the us-west-2 (Oregon) region in your account: | |
|
|
||
| 1. Push your container to a registry somewhere (e.g., [Docker Hub](https://hub.docker.com/), [Amazon ECR](https://aws.amazon.com/ecr/)). | ||
| 2. Copy one of the existing service templates in [services/*](/services). | ||
| 3. Update the `ContainerName` and `Image` parameters to point to your container image instead of the example container. | ||
| 3. Update the `ContainerName` and `Image` parameters to point to your container image instead of the example container. Also make sure the `ContainerName` of property `LoadBalancers` of the ECS service matches with the `Name` in `ContainerDefinitions` property of `TaskDefinition`. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it also necessary to change the |
||
| 4. Increment the `ListenerRule` priority number (no two services can have the same priority number - this is used to order the ALB path based routing rules). | ||
| 5. Copy one of the existing service definitions in [master.yaml](master.yaml) and point it at your new service template. Specify the HTTP `Path` at which you want the service exposed. | ||
| 5. Copy one of the existing service definitions in [master.yaml](master.yaml) and point it at your new service template. Specify the HTTP `Path` at which you want the service exposed. Upload the `service.yaml` file of your new service to S3 and update its link in `master.yaml` | ||
| 6. Deploy the templates as a new stack, or as an update to an existing stack. | ||
|
|
||
| ### Setup centralized container logging | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do we do to update CF with a new version of the
master.yamlfor an existing stack? Do we just substituteupdate-stackparameter for thecreate-stackparameter here?