Skip to content

Conversation

@didoo
Copy link
Contributor

@didoo didoo commented Oct 27, 2025

πŸ“Œ Summary

This PR contains the code changes for the actual dry-run of the HDS migration/carbonization.

This PR is based on top of #3241

πŸ› οΈ Detailed description

In this PR I have added new tokens (where needed) and$modes definitions in src JSON tokens for:

  • typography
  • color/semantic and core/palette
  • badge/badge-count
  • button
  • modal
  • file/text-input
  • file/radio-card

Then I have updated the CSS styling to use the newly created component-level tokens.

Finally, I have

  • re-generated the "themed" tokens in output
  • update the temporary CSS files (components + themed tokens) in showcase public folder

πŸ› οΈ How to test

Note

This is a dry-run, not a final implementation, so the goal was to learn and discover, not perfection or production-ready code; the proper "final" design tokens and styles will be implemented during the proper "migration" (next phase).

Open the different "carbonized" pages and see how the HDS components are rendered, and how the Carbon Web components are rendered, and what are the differences (some are very similar, others are quite different).

Note: the implementation of focus rings for the component will be done in separate work stream.

If you want, you can also test the adoption in the consumers' application (see PRs below).

πŸ”— External links

Jira tickets:

Consumer testing PRs:


πŸ‘€ Component checklist

  • Percy was checked for any visual regression
  • A changelog entry was added via Changesets if needed (see templates here)
    • changelogs will be added in the main feature branch

πŸ’¬ Please consider using conventional comments when reviewing this PR.

πŸ“‹ PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@didoo didoo requested a review from a team as a code owner October 27, 2025 18:53
@vercel
Copy link

vercel bot commented Oct 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Dec 3, 2025 10:11pm
hds-website Ready Ready Preview Dec 3, 2025 10:11pm

@didoo didoo marked this pull request as draft October 27, 2025 18:53
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/carbonization-pages-scaffolding branch from 86a4951 to 0a9791e Compare October 27, 2025 19:35
@didoo didoo force-pushed the project-solar/phase-1/HDS-5202-5203-5204/dry-run-foundations branch from 3731bea to 60813bf Compare October 27, 2025 19:36
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/carbonization-pages-scaffolding branch from 0a9791e to 06337a0 Compare October 27, 2025 20:59
@didoo didoo force-pushed the project-solar/phase-1/HDS-5202-5203-5204/dry-run-foundations branch from 60813bf to d9c624f Compare October 27, 2025 21:00
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/carbonization-pages-scaffolding branch from 06337a0 to 94eef11 Compare October 28, 2025 19:47
@didoo didoo force-pushed the project-solar/phase-1/HDS-5202-5203-5204/dry-run-foundations branch from d9c624f to 1a2dc30 Compare October 28, 2025 19:54
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/carbonization-pages-scaffolding branch from 94eef11 to 5eaa1a9 Compare October 28, 2025 20:42
@didoo didoo force-pushed the project-solar/phase-1/HDS-5202-5203-5204/dry-run-foundations branch from 1a2dc30 to d9b9424 Compare October 28, 2025 20:45
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/carbonization-pages-scaffolding branch from 5eaa1a9 to 4ebba11 Compare October 28, 2025 21:39
@didoo didoo force-pushed the project-solar/phase-1/HDS-5202-5203-5204/dry-run-foundations branch from d9b9424 to 034f90f Compare October 28, 2025 21:40
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/carbonization-pages-scaffolding branch from 4ebba11 to de9fc57 Compare October 28, 2025 22:21
@didoo didoo force-pushed the project-solar/phase-1/HDS-5202-5203-5204/dry-run-foundations branch from 034f90f to a7961ca Compare October 28, 2025 22:28
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/carbonization-pages-scaffolding branch 2 times, most recently from e128d96 to d3f3f0d Compare December 3, 2025 19:27
Base automatically changed from project-solar/phase-1/HDS-5242_showcase/carbonization-pages-scaffolding to project-solar/phase-1-main-feature-branch December 3, 2025 21:38
@didoo didoo force-pushed the project-solar/phase-1/HDS-5202-5203-5204/dry-run-foundations branch from 2e4a003 to cb62d03 Compare December 3, 2025 21:54
Copy link
Contributor

@dchyun dchyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks all good to me 🟒. Just have one question around our token nomenclature.

@didoo didoo merged commit b5c7548 into project-solar/phase-1-main-feature-branch Dec 5, 2025
22 of 23 checks passed
@didoo didoo deleted the project-solar/phase-1/HDS-5202-5203-5204/dry-run-foundations branch December 5, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants