-
Notifications
You must be signed in to change notification settings - Fork 49
[06] [Project Solar / Phase 1 / Dry-run] Migration dry-run for foundations and components #3332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
didoo
merged 16 commits into
project-solar/phase-1-main-feature-branch
from
project-solar/phase-1/HDS-5202-5203-5204/dry-run-foundations
Dec 5, 2025
Merged
[06] [Project Solar / Phase 1 / Dry-run] Migration dry-run for foundations and components #3332
didoo
merged 16 commits into
project-solar/phase-1-main-feature-branch
from
project-solar/phase-1/HDS-5202-5203-5204/dry-run-foundations
Dec 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
86a4951 to
0a9791e
Compare
3731bea to
60813bf
Compare
0a9791e to
06337a0
Compare
60813bf to
d9c624f
Compare
06337a0 to
94eef11
Compare
d9c624f to
1a2dc30
Compare
94eef11 to
5eaa1a9
Compare
1a2dc30 to
d9b9424
Compare
5eaa1a9 to
4ebba11
Compare
d9b9424 to
034f90f
Compare
4ebba11 to
de9fc57
Compare
034f90f to
a7961ca
Compare
e128d96 to
d3f3f0d
Compare
Base automatically changed from
project-solar/phase-1/HDS-5242_showcase/carbonization-pages-scaffolding
to
project-solar/phase-1-main-feature-branch
December 3, 2025 21:38
16 tasks
2e4a003 to
cb62d03
Compare
β¦nd components, to copy relevant CSS files to showcase public folder
β¦palette` src JSON tokens
β¦ updated CSS styling to use them
β¦es in other componentsβ files
β¦public folder p
cb62d03 to
59aacb2
Compare
dchyun
reviewed
Dec 4, 2025
Contributor
dchyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks all good to me π’. Just have one question around our token nomenclature.
dchyun
approved these changes
Dec 4, 2025
b5c7548
into
project-solar/phase-1-main-feature-branch
22 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
This PR contains the code changes for the actual dry-run of the HDS migration/carbonization.
This PR is based on top of #3241
π οΈ Detailed description
In this PR I have added new tokens (where needed) and
$modesdefinitions insrcJSON tokens for:typographycolor/semanticandcore/palettebadge/badge-countbuttonmodalfile/text-inputfile/radio-cardThen I have updated the CSS styling to use the newly created component-level tokens.
Finally, I have
π οΈ How to test
Note
This is a dry-run, not a final implementation, so the goal was to learn and discover, not perfection or production-ready code; the proper "final" design tokens and styles will be implemented during the proper "migration" (next phase).
Open the different "carbonized" pages and see how the HDS components are rendered, and how the Carbon Web components are rendered, and what are the differences (some are very similar, others are quite different).
Note: the implementation of focus rings for the component will be done in separate work stream.
If you want, you can also test the adoption in the consumers' application (see PRs below).
π External links
Jira tickets:
Bage/BadgeCount: https://hashicorp.atlassian.net/browse/HDS-5664Button: https://hashicorp.atlassian.net/browse/HDS-5665Modal: https://hashicorp.atlassian.net/browse/HDS-5685Form/RadioCard: https://hashicorp.atlassian.net/browse/HDS-5684Consumer testing PRs:
π Component checklist
A changelog entry was added via Changesets if needed (see templates here)π¬ Please consider using conventional comments when reviewing this PR.
π PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.