-
Notifications
You must be signed in to change notification settings - Fork 109
H-5768: Quick Simulation in Edit Mode, and disable Simulate temporarily #8195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ae0b9a1 to
1d58d6c
Compare
2f6ebba to
33209de
Compare
38a85b3 to
99b5eb3
Compare
33209de to
e26ecc9
Compare
e26ecc9 to
97f0212
Compare
99b5eb3 to
ec63ab3
Compare
…ly while Simulation is running
094e1a7 to
87b914c
Compare
| <li | ||
| key={`${group.entityId}-${itemGroup.subType}-${ | ||
| diagnostic.start ?? index | ||
| }`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate React keys when diagnostics share same position
The React list key uses diagnostic.start ?? index, meaning the array index is only used as fallback when start is undefined. When two TypeScript diagnostics occur at the same character position (which is possible for certain code patterns), both would have the same key like entityId-lambda-42, causing duplicate React keys. This could lead to incorrect DOM updates and React console warnings. The previous implementation used just index which always produced unique keys.
Your organization requires reapproval when changes are made, so Graphite has dismissed approvals. See the output of git range-diff at https://github.com/hashintel/hash/actions/runs/20468286757

🌟 What is the purpose of this PR?
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
🐾 Next steps
🛡 What tests cover this?
❓ How to test this?