Skip to content

Conversation

@kube
Copy link
Collaborator

@kube kube commented Dec 17, 2025

🌟 What is the purpose of this PR?

  • Wrap margin/padding reset in index.html by @layer reset
    • Fixes issues with padding and margin not being applied when using Panda.
  • Merge two vite.config files (lib and site) into a single one with two modes.
  • Start extracting some styles from some components.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • modifies an npm-publishable library and I have added a changeset file(s)

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

🐾 Next steps

  • Extract styles from more components

❓ How to test this?

  • Use latest Petrinaut deploy

@github-actions github-actions bot added area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team labels Dec 17, 2025
@kube kube changed the title Single vite.config H-5850: Fix PandaCSS and single vite.config Dec 17, 2025
@kube kube marked this pull request as ready for review December 17, 2025 19:09
@cursor
Copy link

cursor bot commented Dec 17, 2025

PR Summary

Unifies Vite config with mode-based lib/site builds and updates/reset styles, extracting component styles into shared css/cva with minor layout tweaks.

  • Build/Config:
    • Merge lib/site Vite configs into a single vite.config.ts with mode-based behavior (--mode=lib for library, default for demo site). Adds conditional dts plugin, define shim, and optimizeDeps config; removes demo-site/vite.config.ts. Updates package.json scripts accordingly.
  • Styles/UI:
    • Wrap global margin/padding reset in @layer reset in demo-site/index.html; add .petrinaut-root background in src/index.css.
    • Extract and centralize component styles via css/cva for Menu, Bottom Bar (bottom-bar, diagnostics-indicator, toolbar-modes), and mode-selector, with small spacing/shadow/position tweaks.
  • Changeset: Add patch note for @hashintel/petrinaut.

Written by Cursor Bugbot for commit bf23535. This will update automatically on new commits. Configure here.

@kube kube changed the base branch from cf/h-5684-implement-live-checks-on-sdcpn-validity to graphite-base/8194 December 17, 2025 22:16
@kube kube force-pushed the cf/h-5850-fix-pandacss-config-and-usage-in-petrinaut branch from 2f6ebba to 33209de Compare December 17, 2025 23:05
@kube kube changed the base branch from graphite-base/8194 to cf/h-5684-implement-live-checks-on-sdcpn-validity December 17, 2025 23:05
@kube kube changed the base branch from cf/h-5684-implement-live-checks-on-sdcpn-validity to graphite-base/8194 December 19, 2025 09:39
@kube kube force-pushed the graphite-base/8194 branch from dc8e3b9 to a5c3883 Compare December 19, 2025 09:39
@kube kube force-pushed the cf/h-5850-fix-pandacss-config-and-usage-in-petrinaut branch from 33209de to e26ecc9 Compare December 19, 2025 09:39
@kube kube changed the base branch from graphite-base/8194 to cf/h-5684-implement-live-checks-on-sdcpn-validity December 19, 2025 09:40
@kube kube force-pushed the cf/h-5850-fix-pandacss-config-and-usage-in-petrinaut branch from e26ecc9 to 97f0212 Compare December 19, 2025 10:37
Base automatically changed from cf/h-5684-implement-live-checks-on-sdcpn-validity to main December 19, 2025 14:38
@kube kube force-pushed the cf/h-5850-fix-pandacss-config-and-usage-in-petrinaut branch from 97f0212 to fb457f5 Compare December 19, 2025 15:54
@kube kube added this pull request to the merge queue Dec 22, 2025
Merged via the queue into main with commit d28482a Dec 22, 2025
41 checks passed
@kube kube deleted the cf/h-5850-fix-pandacss-config-and-usage-in-petrinaut branch December 22, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

3 participants