-
Notifications
You must be signed in to change notification settings - Fork 179
feat: Added pipeline operation timeout detection #21663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Added pipeline operation timeout detection #21663
Conversation
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #21663 +/- ##
============================================
+ Coverage 70.62% 70.66% +0.03%
- Complexity 24353 24367 +14
============================================
Files 2673 2673
Lines 104202 104262 +60
Branches 10935 10937 +2
============================================
+ Hits 73591 73672 +81
+ Misses 26567 26547 -20
+ Partials 4044 4043 -1
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
.../hedera-app/src/main/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnection.java
Outdated
Show resolved
Hide resolved
# Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnection.java # hedera-node/hedera-app/src/test/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnectionTest.java
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
565a49d to
582fc3b
Compare
|
A mirror PR is created for this work |
.../hedera-app/src/main/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnection.java
Outdated
Show resolved
Hide resolved
…eads Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
|
We should also have timeouts around creating the PbjGrpcClient and pipeline |
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
# Conflicts: # hedera-node/docs/design/app/blocks/BlockNodeConnection.md # hedera-node/hedera-app/src/main/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnection.java # hedera-node/hedera-app/src/test/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnectionTest.java # hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/BlockNodeConnectionConfig.java
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
.../hedera-app/src/main/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnection.java
Show resolved
Hide resolved
...-node/hedera-config/src/main/java/com/hedera/node/config/data/BlockNodeConnectionConfig.java
Outdated
Show resolved
Hide resolved
...era-app/src/test/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnectionTest.java
Outdated
Show resolved
Hide resolved
...era-app/src/test/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnectionTest.java
Outdated
Show resolved
Hide resolved
…hanged default pipeline timeout to 3s Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
# Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnection.java # hedera-node/hedera-app/src/test/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnectionTest.java
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
|
Can we please get the rolling log file renamed from blocknode-comms.log to block-node-comms.log |
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks are passing on the mirror PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Seems unrelated to SC
Description:
Closes #21605