Skip to content

Conversation

petreze
Copy link
Contributor

@petreze petreze commented Oct 20, 2025

Description:
A mirror PR for the following PR

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

AlexKehayov and others added 6 commits October 16, 2025 14:55
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnection.java
#	hedera-node/hedera-app/src/test/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnectionTest.java
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
@petreze petreze self-assigned this Oct 20, 2025
@petreze petreze requested review from a team as code owners October 20, 2025 15:45
@petreze petreze requested a review from leninmehedy October 20, 2025 15:45
@lfdt-bot
Copy link

lfdt-bot commented Oct 20, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 94.36620% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...app/blocks/impl/streaming/BlockNodeConnection.java 96.96% 1 Missing and 1 partial ⚠️
...om/hedera/node/app/metrics/BlockStreamMetrics.java 60.00% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #21733   +/-   ##
=========================================
  Coverage     71.85%   71.85%           
- Complexity    24605    24607    +2     
=========================================
  Files          2666     2666           
  Lines        103931   103991   +60     
  Branches      10873    10875    +2     
=========================================
+ Hits          74676    74725   +49     
- Misses        25214    25221    +7     
- Partials       4041     4045    +4     
Files with missing lines Coverage Δ Complexity Δ
...ra/node/config/data/BlockNodeConnectionConfig.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...app/blocks/impl/streaming/BlockNodeConnection.java 90.81% <96.96%> (+0.60%) 72.00 <2.00> (+3.00)
...om/hedera/node/app/metrics/BlockStreamMetrics.java 72.24% <60.00%> (-0.28%) 29.00 <0.00> (ø)

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production
Copy link

codacy-production bot commented Oct 20, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 95.77%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6465ff6) 103836 78672 75.77%
Head commit (006f588) 103896 (+60) 78725 (+53) 75.77% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21733) 71 68 95.77%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants