-
Notifications
You must be signed in to change notification settings - Fork 91
feat: stop fetching transactions data when its not needed #4598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: stop fetching transactions data when its not needed #4598
Conversation
Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
…milar methods (hiero-ledger#4598) Signed-off-by: Mariusz Jasuwienas <mariusz@jasuwienas.pl>
…o-ledger#4598) Signed-off-by: Mariusz Jasuwienas <mariusz@jasuwienas.pl>
…o-ledger#4598) Signed-off-by: Mariusz Jasuwienas <mariusz@jasuwienas.pl>
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #4598 +/- ##
===========================================
- Coverage 95.52% 68.67% -26.86%
===========================================
Files 127 128 +1
Lines 20493 20651 +158
Branches 1760 563 -1197
===========================================
- Hits 19576 14182 -5394
- Misses 898 6458 +5560
+ Partials 19 11 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 73 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work! Left a question
updated: also same idea with this comment #4587 (comment), I think we should use an action-oriented phrasing for title so it matches the conventional and also other commits in the repo.
|
@quiet-node could you run the pipelines and merge it for me, please? 🙏 I still don’t have access, unfortunately… |
Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com> Signed-off-by: Mariusz Jasuwienas <mariusz@jasuwienas.pl>
Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com> Signed-off-by: Mariusz Jasuwienas <mariusz@jasuwienas.pl> Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Description
Fetching the recent account transactions is not really needed, unless we want to query for the balance from the past, but not before 15 minutes ago (balance from the last 15 minutes, expect for current balance).
Related issue(s)
Fixes #4553
Testing Guide
Two alternatives:
Checklist