Merged PHP7 and PHP5 code #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IonBazan
force-pushed
the
merge-php-code
branch
from
2150cb9 to
64b8658
Compare
Author
|
This still needs some fixes for PHP 5. I will review the changes and fix this. |
IonBazan
force-pushed
the
merge-php-code
branch
from
f9c13dc to
4bce01f
Compare
IonBazan
force-pushed
the
merge-php-code
branch
from
4bce01f to
d722041
Compare
Author
|
This should also fix #30 - test added |
IonBazan
force-pushed
the
merge-php-code
branch
from
2a5ae6f to
6fd3383
Compare
IonBazan
force-pushed
the
merge-php-code
branch
from
6fd3383 to
a34c5b1
Compare
hnw
reviewed
Nov 26, 2017
| zend_long sec, usec; | ||
| #else | ||
| long sec, usec; | ||
| #endif |
Owner
There was a problem hiding this comment.
zend_long always means 64bit integer on 64bit system, however long has 32bit length on 64bit-Windows system. This fix causes backward-compatibility problem.
Author
There was a problem hiding this comment.
IonBazan
force-pushed
the
merge-php-code
branch
3 times, most recently
from
1f4b733 to
ef2ddad
Compare
IonBazan
force-pushed
the
merge-php-code
branch
from
ef2ddad to
87c1e9a
Compare
Author
|
@hnw Can you review this again? |
|
Ping @hnw :) |
Author
|
@hnw ping |
cs278
pushed a commit
to kiddivouchers/php-timecop
that referenced
this pull request
Jun 19, 2018
cs278
pushed a commit
to kiddivouchers/php-timecop
that referenced
this pull request
Jun 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to merge the PHP5 and PHP7 code to ease the maintaining. I've tested it locally on 5.6 and 7.1.
The next step is to separate some of version-specific functions back to different files to make it more readable.