Introduce ha-dropdown #27417
Introduce ha-dropdown #27417
Conversation
silamon
added
the
needs design preview
|
We need to add shadows. There is already a PR for this: #27320 Please use (md) when this will be available. |
| --wa-color-danger-on-quiet: var(--ha-color-on-danger-quiet); | ||
| --wa-color-text-normal: var(--ha-color-text-primary); | ||
| --wa-color-surface-default: var(--card-background-color); |
There was a problem hiding this comment.
| --wa-color-surface-default: var(--card-background-color); | |
| --wa-color-surface-default: var(--ha-color-surface-default); |
| --wa-color-text-normal: var(--ha-color-text-primary); | ||
| --wa-color-surface-default: var(--card-background-color); | ||
| --wa-color-surface-raised: var(--ha-dialog-surface-background, var(--mdc-theme-surface, #fff)); |
There was a problem hiding this comment.
We should use a semantic color here, but I am not sure which one. Where is this color used?
@marcinbauer85 can you help out here please?
| import { css, type CSSResultGroup } from "lit"; | ||
| import { customElement, property } from "lit/decorators"; | ||
|
|
||
| @customElement("ha-dropdown") |
There was a problem hiding this comment.
add js docs with reference to WA
| import { css, type CSSResultGroup } from "lit"; | ||
| import { customElement } from "lit/decorators"; | ||
|
|
||
| @customElement("ha-dropdown-item") |
There was a problem hiding this comment.
add js docs with reference to WA
| title: Dropdown | ||
| --- | ||
|
|
||
| # Dropdown `<ha-dropdown>` |
There was a problem hiding this comment.
Add more docs please. When to use it and reference to WA docs
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
4 participants
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: