Skip to content

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Oct 8, 2025

reported by @zucchini-nlp on slack

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I ran some tests in transformers using this branch and everything seems to be passing now, including ForwardRef

@Wauplin Wauplin merged commit 1c39425 into v1.0-release Oct 8, 2025
20 checks passed
@Wauplin Wauplin deleted the fix-forward-ref-validation-if-total-false branch October 8, 2025 11:49
@Wauplin
Copy link
Contributor Author

Wauplin commented Oct 8, 2025

Great! I've shipped v1.0.0.rc4 with the fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants