Skip to content

Fix forward ref validation if total false #3423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
Merged

Fix forward ref validation if total false #3423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/huggingface_hub/dataclasses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,11 +431,11 @@ def type_validator(name: str, value: Any, expected_type: Any) -> None:
elif origin is Required:
if value is _TYPED_DICT_DEFAULT_VALUE:
raise TypeError(f"Field '{name}' is required but missing.")
_validate_simple_type(name, value, args[0])
type_validator(name, value, args[0])
elif origin is NotRequired:
if value is _TYPED_DICT_DEFAULT_VALUE:
return
_validate_simple_type(name, value, args[0])
type_validator(name, value, args[0])
else:
raise TypeError(f"Unsupported type for field '{name}': {expected_type}")

Expand Down
8 changes: 8 additions & 0 deletions tests/test_utils_strict_dataclass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,6 +671,13 @@ class ConfigDict(TypedDict):
optional_value: Optional[int]


class ConfigDictIncomplete(TypedDict, total=False):
str_value: str
positive_int_value: Annotated[int, positive_int]
forward_ref_value: "ForwardDtype"
optional_value: Optional[int]


@pytest.mark.parametrize(
"data",
[
Expand All @@ -680,6 +687,7 @@ class ConfigDict(TypedDict):
)
def test_typed_dict_valid_data(data: dict):
validate_typed_dict(ConfigDict, data)
validate_typed_dict(ConfigDictIncomplete, data)


@pytest.mark.parametrize(
Expand Down