Skip to content

Conversation

@acelaya
Copy link
Collaborator

@acelaya acelaya commented Jun 27, 2025

Make the share annotation component implicitly display a subtle UI feedback in the form of a tick that appears for 1.5 seconds, when the URL is copied to the clipboard, so that it doesn't feel like nothing happened if onCopy was not provided.

Grabacion.de.pantalla.desde.2025-06-27.12-55-20.webm

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to extract this hook somewhere else, as it's a pattern we have used in a couple of places already.

@acelaya acelaya force-pushed the copy-indicator branch 6 times, most recently from 3b03b2b to cefc37c Compare June 27, 2025 11:54
@acelaya acelaya requested a review from robertknight June 27, 2025 11:54
@acelaya acelaya marked this pull request as ready for review June 27, 2025 11:54
Copy link
Contributor

@robertknight robertknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acelaya acelaya merged commit 6eb440a into main Jun 27, 2025
2 checks passed
@acelaya acelaya deleted the copy-indicator branch June 27, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants