-
Notifications
You must be signed in to change notification settings - Fork 1
Briefly display a tick after copying an annotation share URL #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import { delay, mount } from '@hypothesis/frontend-testing'; | ||
| import sinon from 'sinon'; | ||
|
|
||
| import { useTimeout } from '../use-timeout'; | ||
|
|
||
| describe('useTimeout', () => { | ||
| let fakeSetTimeout; | ||
| let fakeClearTimeout; | ||
| let currentSetTimeout; | ||
|
|
||
| beforeEach(() => { | ||
| fakeSetTimeout = sinon | ||
| .stub() | ||
| .callsFake(callback => setTimeout(callback, 0)); | ||
| fakeClearTimeout = sinon.stub(); | ||
| currentSetTimeout = undefined; | ||
| }); | ||
|
|
||
| function TestComponent() { | ||
| currentSetTimeout = useTimeout(fakeSetTimeout, fakeClearTimeout); | ||
| return null; | ||
| } | ||
|
|
||
| function createComponent() { | ||
| return mount(<TestComponent />); | ||
| } | ||
|
|
||
| it('calls setTimeout when returned setTimeout-like callback is invoked', async () => { | ||
| const callback = sinon.stub(); | ||
| createComponent(); | ||
|
|
||
| assert.notCalled(fakeSetTimeout); | ||
| currentSetTimeout(callback, 500); | ||
| assert.calledWith(fakeSetTimeout, sinon.match.func, 500); | ||
|
|
||
| // The callback passed to the timeout will also be called after the timeout | ||
| await delay(0); | ||
| assert.called(callback); | ||
| }); | ||
|
|
||
| it('clears current timeout when unmounted', () => { | ||
| fakeSetTimeout.returns(1); | ||
| const wrapper = createComponent(); | ||
|
|
||
| currentSetTimeout(sinon.stub(), 500); | ||
|
|
||
| wrapper.unmount(); | ||
| assert.called(fakeClearTimeout); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import { useCallback, useEffect, useRef } from 'preact/hooks'; | ||
|
|
||
| /** | ||
| * Returns a setTimeout-compatible stable function, which automatically clears | ||
| * the previously scheduled callback every time it's called. | ||
| * | ||
| * The timeout instance is not returned, as the hook internally handles | ||
| * clearing it. | ||
| */ | ||
| export function useTimeout( | ||
| /* istanbul ignore next - test seam */ | ||
| setTimeout_: typeof setTimeout = setTimeout, | ||
| /* istanbul ignore next - test seam */ | ||
| clearTimeout_: typeof clearTimeout = clearTimeout, | ||
| ): (callback: () => void, delay: number) => void { | ||
| const timeoutRef = useRef<ReturnType<typeof setTimeout_> | null>(null); | ||
| const clearCurrentTimeout = useCallback(() => { | ||
| if (timeoutRef.current) { | ||
| clearTimeout_(timeoutRef.current); | ||
| } | ||
| }, [clearTimeout_]); | ||
|
|
||
| // When unmounted, clear the last timeout, if any | ||
| useEffect(() => { | ||
| return clearCurrentTimeout; | ||
| }, [clearCurrentTimeout]); | ||
|
|
||
| return useCallback( | ||
| (callback, delay) => { | ||
| clearCurrentTimeout(); | ||
| timeoutRef.current = setTimeout_(() => { | ||
| callback(); | ||
| timeoutRef.current = null; | ||
| }, delay); | ||
| }, | ||
| [clearCurrentTimeout, setTimeout_], | ||
| ); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to extract this hook somewhere else, as it's a pattern we have used in a couple of places already.