Skip to content

Fix crash on cycle in EDE change propagation #8634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Fix crash on cycle in EDE change propagation #8634

wants to merge 25 commits into from

Conversation

khanaffan
Copy link
Contributor

@khanaffan khanaffan commented Oct 14, 2025 •
edited
Loading

imodel-native: iTwin/imodel-native#1246

  1. saveChanges() will throw exception if there were cycle in EDE graph.
  2. Add test coverage for EDE.

@khanaffan khanaffan mentioned this pull request Oct 14, 2025
Merged
@khanaffan khanaffan marked this pull request as ready for review October 14, 2025 12:01
@khanaffan khanaffan requested a review from a team as a code owner October 14, 2025 12:01
pmconne
pmconne reviewed Oct 14, 2025
View reviewed changes
pmconne
pmconne reviewed Oct 14, 2025
View reviewed changes
@khanaffan khanaffan enabled auto-merge (squash) October 15, 2025 15:02
ColinKerr
ColinKerr reviewed Oct 15, 2025
View reviewed changes
ColinKerr
ColinKerr reviewed Oct 15, 2025
View reviewed changes
ColinKerr
ColinKerr reviewed Oct 15, 2025
View reviewed changes
ColinKerr
ColinKerr reviewed Oct 15, 2025
View reviewed changes
@khanaffan khanaffan disabled auto-merge October 15, 2025 20:21
@khanaffan khanaffan enabled auto-merge (squash) October 16, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmconne pmconne pmconne approved these changes

@ColinKerr ColinKerr ColinKerr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khanaffan @pmconne @ColinKerr