-
Notifications
You must be signed in to change notification settings - Fork 228
Fix crash on cycle in EDE change propagation #8634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+965
−5
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
787cf5a
WIP
khanaffan 9314b71
Merge branch 'master' of https://github.com/iTwin/itwinjs-core into a…
khanaffan 25a73df
fix
khanaffan b361b29
fix
khanaffan 394f707
WIP
khanaffan f53a47e
Improve test
khanaffan 3272184
improve test
khanaffan 429821f
Merge branch 'master' of https://github.com/iTwin/itwinjs-core into a…
khanaffan 43810e6
fix
khanaffan c556396
WIP
khanaffan bf88123
fix lint error
khanaffan 3f81785
remove only
khanaffan 49989ed
rush changes
khanaffan 14597c9
Merge branch 'master' into affank/ede-test
khanaffan ced66be
rename EDE.test.ts to ElementDrivesElement.test.ts
khanaffan 772c244
Merge branch 'affank/ede-test' of https://github.com/iTwin/itwinjs-co…
khanaffan 643c84e
skip perf test
khanaffan 9e9afcc
skip flaky test
khanaffan 3249c73
Merge branch 'master' into affank/ede-test
khanaffan 53b7c07
Merge branch 'master' into affank/ede-test
khanaffan 9374fc2
fixes
khanaffan 98e8335
update graphs
khanaffan 474832f
Merge branch 'master' into affank/ede-test
khanaffan 1e20343
fix
khanaffan abe1155
Merge branch 'master' into affank/ede-test
khanaffan c29f6c2
Merge branch 'master' into affank/ede-test
khanaffan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
common/changes/@itwin/core-backend/affank-ede-test_2025-10-14-11-57.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@itwin/core-backend", | ||
| "comment": "Fix crash when their is a cycle in EDE.", | ||
| "type": "none" | ||
| } | ||
| ], | ||
| "packageName": "@itwin/core-backend" | ||
| } | ||
10 changes: 10 additions & 0 deletions
10
common/changes/@itwin/core-bentley/affank-ede-test_2025-10-14-11-57.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@itwin/core-bentley", | ||
| "comment": "Fix crash when their is a cycle in EDE.", | ||
pmconne marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "type": "none" | ||
| } | ||
| ], | ||
| "packageName": "@itwin/core-bentley" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.