Fix broken parameters in baseplate options #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two issues I found in the baseplate file: 1. Use the correct magnet hole option when calling `calculate_offset`. Looks like the options struct was reconfigured to have its name as the first element, but this usage wasn't updated to increment the index up by one. 2. The offset logic for the skeletonized baseplate incorrectly adds about 3mm of unneeded plastic to the bottom when no screw holes are specified. Not sure if this is intentional, but I don't see why it would be needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues I found in the baseplate file:
calculate_offset. Looks like the options struct was reconfigured to have its name as the first element, but this usage wasn't updated to increment the index up by one.