fix(web): fix base context-state validation 🚂 #14883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After changes added in #14880, one of our unit tests failed. After lots of investigation, it turns out that the `isSubstitutionAlignable` does not catch certain cases that `determineContextSlideTransform` does. The latter does need some improvement to work as a fix, but a small change lets it pick up the slack and replace the former. As it's also used during context-state transition, re-using the same method in both places gives us far more confidence that we won't have an error the second time around. Build-bot: skip build:web Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
keymanapp-test-bot
bot
changed the title
This was referenced Oct 2, 2025
jahorton
added a commit
that referenced
this pull request
Oct 3, 2025
WIth the changes in #14883, we are now safe to remove the fallback check that was the one place still utilizing ContextTracker.analyzeState. As a result... time for more dead code removal. Build-bot: skip build:web Test-bot: skip
jahorton
added a commit
that referenced
this pull request
Oct 7, 2025
WIth the changes in #14883, we are now safe to remove the fallback check that was the one place still utilizing ContextTracker.analyzeState. As a result... time for more dead code removal. Build-bot: skip build:web Test-bot: skip
…t-state-validation
ermshiperete
approved these changes
Oct 10, 2025
Base automatically changed from
feat/web/interim-legacy-keyer
to
epic/autocorrect
October 16, 2025 14:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After changes to be added in #14880, one of our unit tests will fail without this change. After lots of investigation, it turns out that the
isSubstitutionAlignablefunction does not catch certain cases thatdetermineContextSlideTransformdoes. The latter does need some improvement to work as a fix, but a small change lets it pick up the slack and replace the former.As it's also used during context-state transition, re-using the same method in both places will give us far more confidence that we won't have an error the second time around.
Build-bot: skip build:web
Test-bot: skip