Skip to content

Conversation

@gauron99
Copy link
Contributor

@gauron99 gauron99 commented Dec 16, 2025

  • backporting host auth fixes
  • backporting springboot template bug
  • backporting workflow cleanups

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@knative-prow
Copy link

knative-prow bot commented Dec 16, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2025
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 16, 2025
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2025
@gauron99 gauron99 marked this pull request as ready for review December 16, 2025 11:02
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2025
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 47.61905% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.10%. Comparing base (c9d4c54) to head (f384372).
⚠️ Report is 1 commits behind head on release-1.20.

Files with missing lines Patch % Lines
cmd/client.go 8.33% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.20    #3301      +/-   ##
================================================
+ Coverage         52.79%   60.10%   +7.30%     
================================================
  Files               134      134              
  Lines             13519    13516       -3     
================================================
+ Hits               7138     8124     +986     
+ Misses             5526     4424    -1102     
- Partials            855      968     +113     
Flag Coverage Δ
e2e-tests 41.62% <4.76%> (+11.15%) ⬆️
integration-tests 54.67% <47.61%> (?)
unit-tests 46.72% <47.61%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2025
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2025
@knative-prow
Copy link

knative-prow bot commented Dec 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [gauron99,lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 7052943 into knative:release-1.20 Dec 16, 2025
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants