Skip to content

🌱 e2e: fix AWSMachineTemplate autoscaler test #5765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 e2e: fix AWSMachineTemplate autoscaler test #5765

wants to merge 1 commit into from
+112 −28

Conversation

@LiangquanLi930
Copy link
Contributor

@LiangquanLi930 LiangquanLi930 commented Nov 24, 2025 •
edited
Loading

What type of PR is this?
/kind flake

What this PR does / why we need it:
fix AWSMachineTemplate autoscaler test

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

fix AWSMachineTemplate autoscaler test

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 24, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign richardcase for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-priority needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 24, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 24, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 24, 2025

Hi @LiangquanLi930. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 24, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2025
@chrischdi
Copy link
Member

chrischdi commented Nov 24, 2025

/test help

/retitle 🌱 [WIP] e2e: fix AWSMachineTemplate autoscaler test
/ok-to-test

@k8s-ci-robot k8s-ci-robot changed the title fix PR: 5711 e2e 🌱 [WIP] e2e: fix AWSMachineTemplate autoscaler test Nov 24, 2025
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 24, 2025
@chrischdi
Copy link
Member

chrischdi commented Nov 24, 2025

/test help

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 24, 2025

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build

/test pull-cluster-api-provider-aws-build-docker

/test pull-cluster-api-provider-aws-e2e-blocking

/test pull-cluster-api-provider-aws-test

/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main

/test pull-cluster-api-provider-aws-e2e

/test pull-cluster-api-provider-aws-e2e-clusterclass

/test pull-cluster-api-provider-aws-e2e-conformance

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

/test pull-cluster-api-provider-aws-e2e-eks

/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main

pull-cluster-api-provider-aws-build

pull-cluster-api-provider-aws-build-docker

pull-cluster-api-provider-aws-e2e-blocking

pull-cluster-api-provider-aws-test

pull-cluster-api-provider-aws-verify

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Member

chrischdi commented Nov 24, 2025

/test pull-cluster-api-provider-aws-e2e

1 similar comment
@LiangquanLi930
Copy link
Contributor Author

LiangquanLi930 commented Nov 24, 2025

/test pull-cluster-api-provider-aws-e2e

@LiangquanLi930
Copy link
Contributor Author

LiangquanLi930 commented Nov 24, 2025

/test pull-cluster-api-provider-aws-e2e-eks

@LiangquanLi930
Copy link
Contributor Author

LiangquanLi930 commented Nov 24, 2025

/test pull-cluster-api-provider-aws-e2e

@chrischdi
Copy link
Member

chrischdi commented Nov 24, 2025

xref: tries to take a look at the test failure coming from this PR: #5711 (comment)

It seems to be very flaky!

See: k8s-triage

Example: prow.k8s.io/view/gs/kubernetes-ci-logs/logs/periodic-cluster-api-provider-aws-e2e-eks-canary/1992633554630086656

@LiangquanLi930
Copy link
Contributor Author

LiangquanLi930 commented Nov 24, 2025

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/5765/pull-cluster-api-provider-aws-e2e/1992881339380011008

capa-e2e: [It] [unmanaged] [functional] Workload cluster with AWS SSM Parameter as the Secret Backend should be creatable and deletable

pass

@LiangquanLi930
Copy link
Contributor Author

LiangquanLi930 commented Nov 24, 2025

/test pull-cluster-api-provider-aws-e2e-eks

@nrb
Copy link
Contributor

nrb commented Nov 24, 2025

/test pull-cluster-api-provider-aws-e2e

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2025
@LiangquanLi930
Copy link
Contributor Author

LiangquanLi930 commented Nov 24, 2025

/test pull-cluster-api-provider-aws-e2e-eks

@LiangquanLi930
Copy link
Contributor Author

LiangquanLi930 commented Nov 25, 2025

/test pull-cluster-api-provider-aws-e2e

@LiangquanLi930
Copy link
Contributor Author

LiangquanLi930 commented Nov 25, 2025

/test pull-cluster-api-provider-aws-e2e-eks

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 25, 2025
@LiangquanLi930
Copy link
Contributor Author

LiangquanLi930 commented Nov 25, 2025

/test pull-cluster-api-provider-aws-e2e

@LiangquanLi930
Copy link
Contributor Author

LiangquanLi930 commented Nov 25, 2025

/test pull-cluster-api-provider-aws-e2e-eks

@nrb
Copy link
Contributor

nrb commented Nov 25, 2025

/test pull-cluster-api-provider-aws-e2e

@LiangquanLi930
Copy link
Contributor Author

LiangquanLi930 commented Nov 25, 2025

/test pull-cluster-api-provider-aws-e2e-eks

@chrischdi
Copy link
Member

chrischdi commented Nov 25, 2025

/retitle 🌱 e2e: fix AWSMachineTemplate autoscaler test #5765

@k8s-ci-robot k8s-ci-robot changed the title 🌱 [WIP] e2e: fix AWSMachineTemplate autoscaler test 🌱 e2e: fix AWSMachineTemplate autoscaler test #5765 Nov 25, 2025
@LiangquanLi930 LiangquanLi930 changed the title 🌱 e2e: fix AWSMachineTemplate autoscaler test #5765 🌱 e2e: fix AWSMachineTemplate autoscaler test Nov 26, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 26, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 26, 2025
@LiangquanLi930
Copy link
Contributor Author

LiangquanLi930 commented Nov 26, 2025

/test pull-cluster-api-provider-aws-e2e

@damdo
Copy link
Member

damdo commented Nov 26, 2025

@LiangquanLi930 could you rebase also? TY

@LiangquanLi930 LiangquanLi930 force-pushed the fix-e2e branch 2 times, most recently from 7e094af to ff4df47 Compare November 26, 2025 14:29
damdo
damdo reviewed Nov 26, 2025
View reviewed changes
@LiangquanLi930
fix(controllers): add watches to resolve AWSMachineTemplate e2e race …
32e7d74 
…condition

Add MachineDeployment and KubeadmControlPlane watchers to trigger
AWSMachineTemplate reconciliation, ensuring nodeInfo is populated
before cache sync completes.

Related: kubernetes-sigs#5711
@damdo
Copy link
Member

damdo commented Nov 26, 2025

/test pull-cluster-api-provider-aws-test

@damdo
Copy link
Member

damdo commented Nov 26, 2025

/test pull-cluster-api-provider-aws-e2e

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 26, 2025

@LiangquanLi930: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-e2e-eks ea9e47d link false /test pull-cluster-api-provider-aws-e2e-eks
pull-cluster-api-provider-aws-e2e 32e7d74 link false /test pull-cluster-api-provider-aws-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nrb
Copy link
Contributor

nrb commented Nov 26, 2025

/test pull-cluster-api-provider-aws-e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo damdo left review comments

@fiunchinho fiunchinho Awaiting requested review from fiunchinho

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LiangquanLi930 @k8s-ci-robot @chrischdi @nrb @damdo