[SharedResourcesProblem] [Simplex Scheduler] Simplex scheduler deals with multiple resource constraints #8480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jopperm
reviewed
May 18, 2025
Comment on lines
946
to
949
| auto rsrc = rsrcs[0]; | ||
| unsigned limit = prob.getLimit(rsrc).value_or(0); | ||
| assert(limit > 0); | ||
|
|
There was a problem hiding this comment.
Is this dead code?
Suggested change
| auto rsrc = rsrcs[0]; | |
| unsigned limit = prob.getLimit(rsrc).value_or(0); | |
| assert(limit > 0); |
| @@ -69,3 +69,26 @@ ssp.instance @multiple of "SharedOperatorsProblem" { | |||
| operation<@_1> @last(%5) [t<11>] | |||
| } | |||
| } | |||
|
|
|||
| // CHECK-LABEL: if_else | |||
| ssp.instance @if_else_exclusive of "SharedResourcesProblem" { | |||
There was a problem hiding this comment.
Please add a couple more tests for multi-resource operations that contain potential resource conflicts. I'd like to see:
- Two ops competing for a set of common resources
- Limits > 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
ResourceTypefromOperatorType#8444;