Enable most of the cbuffer tests for clang #280
Merged
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure is the XPASS being resolved in #284 |
Icohedron
approved these changes
Aug 7, 2025
llvm-beanz
reviewed
Aug 7, 2025
| # https://github.com/llvm/llvm-project/issues/110722 | ||
| # XFAIL: Clang | ||
| # https://github.com/llvm/llvm-project/issues/138996 | ||
| # UNSUPPORTED: Clang |
There was a problem hiding this comment.
Do we want this UNSUPPORTED or XFAIL?
There was a problem hiding this comment.
XFAIL. I'll update these.
| @@ -1,4 +1,4 @@ | |||
| if 'Clang' in config.available_features: | |||
| if 'Clang-Vulkan' in config.available_features: | |||
| config.unsupported = True | |||
There was a problem hiding this comment.
Should we just be enabling these now?
There was a problem hiding this comment.
Well, none of these tests pass under vulkan. I could remove this and add XFAILs to the tests directly if you think that makes more sense.
There was a problem hiding this comment.
I don't have a strong feeling, I just want to make sure that we don't somehow lose track and not enable the tests once they do start passing.
These have been working for some time but we never enabled the tests.
bogner
force-pushed
the
2025-07-08-cbuffer-tests
branch
from
2bba62c to
c8007c1
Compare
llvm-beanz
approved these changes
Aug 7, 2025
|
pre-checkin CI is in a bit of a rough spot, but the cbuffer tests themselves are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have been working for some time but we never enabled the tests.