Skip to content

Enable most of the cbuffer tests for clang #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025
Merged

Enable most of the cbuffer tests for clang #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
835bb55
Enable most of the cbuffer tests for clang
bogner May 13, 2025
c8007c1
Use XFAIL, not UNSUPPORTED
bogner Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/Feature/CBuffer/arrays-16bit.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ DescriptorSets:
# DXC's vulkan support does not layout cbuffers compatibly with DXIL
# UNSUPPORTED: Vulkan

# https://github.com/llvm/llvm-project/issues/110722
# https://github.com/llvm/llvm-project/issues/138996
# XFAIL: Clang

# RUN: split-file %s %t
Expand Down
2 changes: 1 addition & 1 deletion test/Feature/CBuffer/lit.local.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
if 'Clang' in config.available_features:
if 'Clang-Vulkan' in config.available_features:
config.unsupported = True

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just be enabling these now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, none of these tests pass under vulkan. I could remove this and add XFAILs to the tests directly if you think that makes more sense.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong feeling, I just want to make sure that we don't somehow lose track and not enable the tests once they do start passing.

# CBuffer bindings seem to be broken under metal
Expand Down
4 changes: 4 additions & 0 deletions test/Feature/CBuffer/structs.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@ DescriptorSets:
# DXC's vulkan support does not layout cbuffers compatibly with DXIL
# UNSUPPORTED: Vulkan

+# Clang trips on 2-element vectors in structs:
+# https://github.com/llvm/llvm-project/issues/123968
+# XFAIL: Clang

# RUN: split-file %s %t
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s
Expand Down
4 changes: 4 additions & 0 deletions test/Feature/CBuffer/vectors-64bit.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ DescriptorSets:
# DXC's vulkan support does not layout cbuffers compatibly with DXIL
# UNSUPPORTED: Vulkan

# Clang trips on 3-element vectors in structs:
# https://github.com/llvm/llvm-project/issues/123968
# XFAIL: Clang

# RUN: split-file %s %t
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s
Expand Down
4 changes: 4 additions & 0 deletions test/Feature/CBuffer/vectors.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ DescriptorSets:
# DXC's vulkan support does not layout cbuffers compatibly with DXIL
# UNSUPPORTED: Vulkan

# Clang trips on 3-element vectors in structs:
# https://github.com/llvm/llvm-project/issues/123968
# XFAIL: Clang

# RUN: split-file %s %t
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s
Expand Down
Loading