Skip to content

[TorchToLinalg] Support lowering AtenReplicationPad3d to linalg #4233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 18, 2025
Merged

[TorchToLinalg] Support lowering AtenReplicationPad3d to linalg #4233

merged 5 commits into from
Jul 18, 2025

Conversation

vinitdeodhar
Copy link
Contributor

Add support of AtenReplicationPad3d in torch dialect and lowering it to linalg backend
AtenReplicationPad3d is lowered using a sequence of tensor.extract_slice and tensor.concat operations consistent with the existing lowerings of AtenReplicationPad1d and AtenReplicationPad2d for the linalg backend

@sahas3 sahas3 requested review from zjgarvey and sahas3 June 17, 2025 14:11
sahas3
sahas3 reviewed Jun 17, 2025
View reviewed changes
@vinitdeodhar
Copy link
Contributor Author

Could you please review this @zjgarvey ?

sahas3
sahas3 approved these changes Jul 2, 2025
View reviewed changes
@vinitdeodhar vinitdeodhar mentioned this pull request Jul 3, 2025
Closed
@vinitdeodhar
Copy link
Contributor Author

@zjgarvey , @zahidwx can you please review ?

@vinitdeodhar vinitdeodhar changed the title Support lowering AtenReplicationPad3d to linalg [TorchToLinalg] Support lowering AtenReplicationPad3d to linalg Jul 10, 2025
@vinitdeodhar
Copy link
Contributor Author

Hi @zjgarvey, can you please review this ?

@zjgarvey
Copy link
Collaborator

Hey, @vinitdeodhar . Would you mind addressing the ci failure first? Let me know if you have trouble debugging and I can help you out.

@vinitdeodhar
Copy link
Contributor Author

Hey, @vinitdeodhar . Would you mind addressing the ci failure first? Let me know if you have trouble debugging and I can help you out.

Hi @zjgarvey the ci failures do not seem to be related to the change and affect other PRs submitted at the time too. I dont have access rights to rerun the job and try again. Here is the error thrown:
torch._dynamo.exc.InternalTorchDynamoError: TimeoutError: Timeout

@zjgarvey
Copy link
Collaborator

Hi @zjgarvey the ci failures do not seem to be related to the change and affect other PRs submitted at the time too. I dont have access rights to rerun the job and try again. Here is the error thrown: torch._dynamo.exc.InternalTorchDynamoError: TimeoutError: Timeout

Can you sync the branch with main so we can re-run?

@vinitdeodhar
Copy link
Contributor Author

Hi @zjgarvey the ci failures do not seem to be related to the change and affect other PRs submitted at the time too. I dont have access rights to rerun the job and try again. Here is the error thrown: torch._dynamo.exc.InternalTorchDynamoError: TimeoutError: Timeout

Can you sync the branch with main so we can re-run?

Thanks ! I synced the branch that it resolved the failures

zjgarvey
zjgarvey approved these changes Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder ping. This mostly looks good to me, just some nit comments.

zjgarvey
zjgarvey approved these changes Jul 18, 2025
View reviewed changes
Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Let me know if you want me to merge.

@vinitdeodhar
Copy link
Contributor Author

Nice, thanks! Let me know if you want me to merge.

Yes, can you help merge the change ?

@zjgarvey zjgarvey merged commit 46c3888 into llvm:main Jul 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahas3 sahas3 sahas3 approved these changes

@zjgarvey zjgarvey zjgarvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinitdeodhar @zjgarvey @sahas3