Code to resolved Aikido reported issue: 12726180 #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snake14
previously approved these changes
Aug 19, 2025
Contributor
snake14
left a comment
snake14
left a comment
There was a problem hiding this comment.
Looks reasonable to me 👍
The fact that this didn't break any tests indicates that we don't have unit tests checking the updated queries. On the plus side, we likely don't have regressions given the integration tests continued to pass.
|
I still don't think this is a complete solution, but it's an improvement from where it was. |
james-hill-matomo
previously approved these changes
Aug 20, 2025
|
@AltamashShaikh may as well merge this. As discussed in TAC we don't need to improve the security further, just validate it's safe already. |
|
@AltamashShaikh Let's just merge this one :) |
Contributor
Author
|
@james-hill-matomo Need approval. |
james-hill-matomo
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code to resolved Aikido reported issue: 12726180
Issue No
https://app.aikido.dev/issues/12726180/detail
Steps to Replicate the Issue
Checklist