Skip to content

Code to resolved Aikido reported issue: 12726180 #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AltamashShaikh merged 3 commits into from
Sep 1, 2025
Merged

Code to resolved Aikido reported issue: 12726180 #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f0ca8c
Code to resolved Aikido reported issue: 12726180
AltamashShaikh Aug 14, 2025
0fd3335
bumped version to 5.1.3
AltamashShaikh Aug 20, 2025
c200716
Merge branch '5.x-dev' into resolve-aikido-12726180
AltamashShaikh Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

5.1.3 - 2025-09-01
- Add support for Sentinel password
- Security hardening

5.1.2 - 2025-07-07
- Textual changes
Expand Down
10 changes: 5 additions & 5 deletions Queue/Backend/MySQL.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public function appendValuesToList($key, $values)
{
$table = $this->makePrefixedKeyListTableName($key);

$query = sprintf('INSERT INTO %s (`list_value`) VALUES (?)', $table);
$query = sprintf('INSERT INTO `%s` (`list_value`) VALUES (?)', $table);
foreach ($values as $value) {
if (empty($value)) {
continue;
Expand Down Expand Up @@ -143,7 +143,7 @@ public function getFirstXValuesFromList($key, $numValues)
}

$table = $this->makePrefixedKeyListTableName($key);
$sql = sprintf('SELECT SQL_NO_CACHE list_value FROM %s ORDER BY idqueuelist ASC LIMIT %d OFFSET 0', $table, (int)$numValues);
$sql = sprintf('SELECT SQL_NO_CACHE list_value FROM `%s` ORDER BY idqueuelist ASC LIMIT %d OFFSET 0', $table, (int)$numValues);

try {
$values = Db::fetchAll($sql);
Expand Down Expand Up @@ -172,7 +172,7 @@ public function hasAtLeastXRequestsQueued($key, $numValuesRequired)
}

$table = $this->makePrefixedKeyListTableName($key);
$sql = sprintf('SELECT SQL_NO_CACHE idqueuelist FROM %s LIMIT %d', $table, (int)$numValuesRequired);
$sql = sprintf('SELECT SQL_NO_CACHE idqueuelist FROM `%s` LIMIT %d', $table, (int)$numValuesRequired);

try {
$values = Db::fetchAll($sql);
Expand All @@ -194,7 +194,7 @@ public function removeFirstXValuesFromList($key, $numValues)
}

$table = $this->makePrefixedKeyListTableName($key);
$sql = sprintf('DELETE FROM %s ORDER BY idqueuelist ASC LIMIT %d', $table, (int)$numValues);
$sql = sprintf('DELETE FROM `%s` ORDER BY idqueuelist ASC LIMIT %d', $table, (int)$numValues);

try {
Db::query($sql);
Expand All @@ -210,7 +210,7 @@ public function removeFirstXValuesFromList($key, $numValues)
public function getNumValuesInList($key)
{
$table = $this->makePrefixedKeyListTableName($key);
$sql = sprintf('SELECT SQL_NO_CACHE max(idqueuelist) - min(idqueuelist) as num_entries FROM %s', $table);
$sql = sprintf('SELECT SQL_NO_CACHE max(idqueuelist) - min(idqueuelist) as num_entries FROM `%s`', $table);
try {
$value = Db::fetchOne($sql);
if ($value === null || $value === false) {
Expand Down