fix: Fix regex validation for connection string in MCP client form #587

KingVibhor · 2025-10-10T08:05:44Z

FIxes : #165

Summary

This PR fixes the regex pattern for validating connection strings in the MCP client form component has incorrect anchoring that allows invalid URLs to pass validation.

Changes

Made changes in the bifrost\ui\app\config\views\mcpClientForm.tsx file
In the line 116, changed : /^(http://|https://|env.[A-Z_]+$)/ to /^(?:http://|https://|env.[A-Z_]+)$/ so that the URL is properly anchored.

Type of change

Affected areas

How to test

Open the MCP Client Form in your application UI.
Try entering various values in the "Connection URL" field:

Valid examples:

Invalid examples (should show a validation error):

ftp://example.com
http://garbageEXTRA
env.my_env_var (lowercase letters)
example.com
http:// (with nothing after)

Submit the form and confirm:

Valid values are accepted.
Invalid values show the error:
"Connection URL must start with http://, https://, or be an environment variable (env.VAR_NAME)"

# Core/Transports
go version
go test ./...

# UI
cd ui
pnpm i || npm i
pnpm test || npm test
pnpm build || npm run build

Breaking changes

Yes
No

If yes, describe impact and migration instructions.

Related issues

Closes #165

Checklist

I read docs/contributing/README.md and followed the guidelines
I added/updated tests where appropriate
I updated documentation where needed
I verified builds succeed (Go and UI)
I verified the CI pipeline passes locally if applicable

coderabbitai · 2025-10-10T08:06:15Z

📝 Walkthrough

Summary by CodeRabbit

Bug Fixes
- Improved Connection URL validation in the MCP Client form to require a complete, valid entry.
- Ensures both http and https URLs are accepted.
- Supports environment variable inputs in the env.VAR_NAME format.
- Prevents partial matches, reducing false positives and delivering clearer validation feedback.

Walkthrough

Replaced the connection URL validation regex in ui/app/config/views/mcpClientForm.tsx with a non-capturing group and moved the end anchor so the entire input must match either an http:///https:// URL or an env.VAR_NAME pattern (full-string match).

Changes

Cohort / File(s)	Summary
Validation regex fix `ui/app/config/views/mcpClientForm.tsx`	Replaced `/^(http://

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant User
  participant Form
  participant Validator
  participant App

  User->>Form: Enter connection string
  Form->>Validator: validate(input)
  note right of Validator #DFF7E0: Regex enforces full-string match\n(?:http://|https://|env.VAR)
  Validator-->>Form: valid / invalid
  Form-->>App: submit if valid
  App-->>User: success / show error

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

I twitched my nose at dangling ends,
Brought anchors close like tidy friends,
HTTP or env so true,
No more stray bits slipping through,
Hop, the form is whole again. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title concisely and accurately describes the primary change by indicating a fix to the regex validation for the connection string in the MCP client form, matching the main focus of the diff and following conventional commit style.
Linked Issues Check	✅ Passed	The change precisely implements the suggested fix from issue #165 by updating the regex to use a non-capturing group with the end-of-string anchor applied to all alternatives and retains the original error message, fully satisfying the linked issue requirements.
Out of Scope Changes Check	✅ Passed	All modifications are confined to the regex validation in the specified MCP client form component, with no unrelated or out-of-scope changes introduced.
Description Check	✅ Passed	The PR description follows the repository template by providing a clear summary, detailed changes, type of change, affected areas, testing instructions, breaking change declaration, related issues, and a completed checklist; while the screenshots/recordings and security considerations sections are not present, their absence does not impede understanding of the change.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 70c7d8c and a2ffd06.

📒 Files selected for processing (1)

ui/app/config/views/mcpClientForm.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

ui/app/config/views/mcpClientForm.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

akshaydeo · 2025-10-10T08:06:35Z

thanks for the PR @KingVibhor - once checks pass; ill merge it

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e33f4f4 and 9d5412c.

📒 Files selected for processing (1)

ui/app/config/views/mcpClientForm.tsx (1 hunks)

ui/app/config/views/mcpClientForm.tsx

akshaydeo · 2025-10-10T08:50:07Z

ui/app/config/views/mcpClientForm.tsx

 					Validator.pattern(
 						form.connection_string || "",
-						/^(http:\/\/|https:\/\/|env\.[A-Z_]+$)/,
+						/^(?:http:?\/\/.+|env\.[A-Z_]+)$/,


this fails for https

@KingVibhor please add test cases as well and re-submit

KingVibhor · 2025-10-13T06:24:05Z

Hey can you please the review the changes that i made to the PR

…

On Fri, 10 Oct 2025 at 14:20, Akshay Deo ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In ui/app/config/views/mcpClientForm.tsx <#587 (comment)>: > @@ -113,7 +113,7 @@ const ClientForm: React.FC<ClientFormProps> = ({ client, open, onClose, onSaved Validator.required(form.connection_string?.trim(), "Connection URL is required"), Validator.pattern( form.connection_string || "", - /^(http:\/\/|https:\/\/|env\.[A-Z_]+$)/, + /^(?:http:?\/\/.+|env\.[A-Z_]+)$/, ***@***.*** (view on web) <https://github.com/user-attachments/assets/bcfe1003-d13c-4fb3-9287-19c4f338ba0b> this fails for https @KingVibhor <https://github.com/KingVibhor> please add test cases as well and re-submit — Reply to this email directly, view it on GitHub <#587 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A5A5QYZJXBNNJ3DOZIUU6Y33W5XNPAVCNFSM6AAAAACIZ7LQDCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMRSGA3DCMJRGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

KingVibhor · 2025-10-13T06:24:40Z

Hey can you please review the changes I made to the PR

…

On Fri, 10 Oct 2025 at 14:20, Akshay Deo ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In ui/app/config/views/mcpClientForm.tsx <#587 (comment)>: > @@ -113,7 +113,7 @@ const ClientForm: React.FC<ClientFormProps> = ({ client, open, onClose, onSaved Validator.required(form.connection_string?.trim(), "Connection URL is required"), Validator.pattern( form.connection_string || "", - /^(http:\/\/|https:\/\/|env\.[A-Z_]+$)/, + /^(?:http:?\/\/.+|env\.[A-Z_]+)$/, ***@***.*** (view on web) <https://github.com/user-attachments/assets/bcfe1003-d13c-4fb3-9287-19c4f338ba0b> this fails for https @KingVibhor <https://github.com/KingVibhor> please add test cases as well and re-submit — Reply to this email directly, view it on GitHub <#587 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A5A5QYZJXBNNJ3DOZIUU6Y33W5XNPAVCNFSM6AAAAACIZ7LQDCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMRSGA3DCMJRGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Fixed regec validation

9d5412c

coderabbitai bot requested changes Oct 10, 2025

View reviewed changes

ui/app/config/views/mcpClientForm.tsx Outdated Show resolved Hide resolved

Addressed review comments

70c7d8c

coderabbitai bot approved these changes Oct 10, 2025

View reviewed changes

akshaydeo requested changes Oct 10, 2025

View reviewed changes

Fix regex validation to support HTTPS URLs in connection strings

a2ffd06

KingVibhor requested a review from akshaydeo October 11, 2025 07:07

akshaydeo closed this Oct 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Fix regex validation for connection string in MCP client form #587

fix: Fix regex validation for connection string in MCP client form #587

Uh oh!

KingVibhor commented Oct 10, 2025

Uh oh!

coderabbitai bot commented Oct 10, 2025 •

edited

Loading

Summary by CodeRabbit

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Uh oh!

akshaydeo commented Oct 10, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

akshaydeo Oct 10, 2025

Uh oh!

KingVibhor commented Oct 13, 2025 via email

Uh oh!

KingVibhor commented Oct 13, 2025 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: Fix regex validation for connection string in MCP client form #587

fix: Fix regex validation for connection string in MCP client form #587

Uh oh!

Conversation

KingVibhor commented Oct 10, 2025

Summary

Changes

Type of change

Affected areas

How to test

Breaking changes

Related issues

Checklist

Uh oh!

coderabbitai bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

akshaydeo commented Oct 10, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

akshaydeo Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

KingVibhor commented Oct 13, 2025 via email

Uh oh!

KingVibhor commented Oct 13, 2025 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Oct 10, 2025 •

edited

Loading