Skip to content

fix: Fix regex validation for connection string in MCP client form #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
+1 −1
Closed

fix: Fix regex validation for connection string in MCP client form #587

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d5412c
Fixed regec validation
Oct 10, 2025
70c7d8c
Addressed review comments
Oct 10, 2025
a2ffd06
Fix regex validation to support HTTPS URLs in connection strings
Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/app/config/views/mcpClientForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ const ClientForm: React.FC<ClientFormProps> = ({ client, open, onClose, onSaved
Validator.required(form.connection_string?.trim(), "Connection URL is required"),
Validator.pattern(
form.connection_string || "",
/^(http:\/\/|https:\/\/|env\.[A-Z_]+$)/,
/^(?:http:?\/\/.+|env\.[A-Z_]+)$/,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

this fails for https

@KingVibhor please add test cases as well and re-submit

"Connection URL must start with http://, https://, or be an environment variable (env.VAR_NAME)",
),
]
Expand Down