Add python bindings for serve/dial #1758
Open
+248
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are going to end up with cases where during bootstrap, we will need to make some initial connections in order to discover the information needed to call attach_to_workers. For instance, in torchx bootstrap, the workers know where the client is, but not vice-versa. While we could use a non-monarch tcp server/client in the bootstrap function, we would have to re-implement a bunch of the connection properties (dial before serve, tls handling). So the most flexible thing seems to be just to expose dial/serve on our channels and then let the bootstrap code use it to get the initial information. Differential Revision: [D86321192](https://our.internmc.facebook.com/intern/diff/D86321192/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86321192/)! [ghstack-poisoned]
This was referenced Nov 5, 2025
meta-cla
bot
added
the
CLA Signed
zdevito
added a commit
that referenced
this pull request
Nov 5, 2025
We are going to end up with cases where during bootstrap, we will need to make some initial connections in order to discover the information needed to call attach_to_workers. For instance, in torchx bootstrap, the workers know where the client is, but not vice-versa. While we could use a non-monarch tcp server/client in the bootstrap function, we would have to re-implement a bunch of the connection properties (dial before serve, tls handling). So the most flexible thing seems to be just to expose dial/serve on our channels and then let the bootstrap code use it to get the initial information. Differential Revision: [D86321192](https://our.internmc.facebook.com/intern/diff/D86321192/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86321192/)! ghstack-source-id: 321115415 Pull Request resolved: #1758
We are going to end up with cases where during bootstrap, we will need to make some initial connections in order to discover the information needed to call attach_to_workers. For instance, in torchx bootstrap, the workers know where the client is, but not vice-versa. While we could use a non-monarch tcp server/client in the bootstrap function, we would have to re-implement a bunch of the connection properties (dial before serve, tls handling). So the most flexible thing seems to be just to expose dial/serve on our channels and then let the bootstrap code use it to get the initial information. Differential Revision: [D86321192](https://our.internmc.facebook.com/intern/diff/D86321192/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86321192/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Nov 5, 2025
Pull Request resolved: #1758 We are going to end up with cases where during bootstrap, we will need to make some initial connections in order to discover the information needed to call attach_to_workers. For instance, in torchx bootstrap, the workers know where the client is, but not vice-versa. While we could use a non-monarch tcp server/client in the bootstrap function, we would have to re-implement a bunch of the connection properties (dial before serve, tls handling). So the most flexible thing seems to be just to expose dial/serve on our channels and then let the bootstrap code use it to get the initial information. Differential Revision: [D86321192](https://our.internmc.facebook.com/intern/diff/D86321192/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86321192/)! ghstack-source-id: 321120719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
We are going to end up with cases where during bootstrap, we will need to make some initial connections in order to discover the information needed to call attach_to_workers. For instance, in torchx bootstrap, the workers know where the client is, but not vice-versa. While we could use a non-monarch tcp server/client in the bootstrap function, we would have to re-implement a bunch of the connection properties (dial before serve, tls handling). So the most flexible thing seems to be just to expose dial/serve on our channels and then let the bootstrap code use it to get the initial information.
Differential Revision: D86321192
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!