[Logging] put the actor name in the python logger #1767
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Injects [actor=<the fully qualified actor name>] into the log message of the python actor. The prefix is configurable by redefining `monarch.actor.per_actor_logging_prefix` callback. Setting to None disables the filter that alters the logs. Hopefully this works pretty broadly since it hooks in as a filter on logging handlers. Differential Revision: [D85994688](https://our.internmc.facebook.com/intern/diff/D85994688/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85994688/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Nov 6, 2025
Injects [actor=<the fully qualified actor name>] into the log message of the python actor. The prefix is configurable by redefining `monarch.actor.per_actor_logging_prefix` callback. Setting to None disables the filter that alters the logs. Hopefully this works pretty broadly since it hooks in as a filter on logging handlers. Differential Revision: [D85994688](https://our.internmc.facebook.com/intern/diff/D85994688/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85994688/)! ghstack-source-id: 321422564 Pull Request resolved: #1767
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in 9863cb2. |
Contributor
|
This pull request has been reverted by 0af6421. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Injects [actor=] into the log message of the python actor.
The prefix is configurable by redefining
monarch.actor.per_actor_logging_prefixcallback. Setting to None disables the filter that alters the logs.Hopefully this works pretty broadly since it hooks in as a filter on logging handlers.
Differential Revision: D85994688
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!