-
Notifications
You must be signed in to change notification settings - Fork 155
refactor: removed commented code, fixes for Standard Gallery validation & updated docs #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* CI Pipeline fix for Client Advisor * added tags in CAdeploy.yml file * add my feature branch * tags changes updated in CAdeploy.yml file * added template name condition based * removed my feature branch from pipeline * Additional Troubleshooting steps
… bice… (#678) * Remove createdby from pipeline and add change Createdby logic in bicep file * Add 'createdBy' parameter to Azure deployment * Add 'createdBy' parameter for tagging
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
feat: Create Separate User Assigned Identity for SQL DB with Specified Access
…emoved the unsued params (#690) * fix: Dev to main (#681) * fix: added tags in CAdeploy.yml file (#675) * CI Pipeline fix for Client Advisor * added tags in CAdeploy.yml file * add my feature branch * tags changes updated in CAdeploy.yml file * added template name condition based * removed my feature branch from pipeline * Additional Troubleshooting steps * fix: Remove createdby from pipeline and add change Createdby logic in bice… (#678) * Remove createdby from pipeline and add change Createdby logic in bicep file * Add 'createdBy' parameter to Azure deployment * Add 'createdBy' parameter for tagging * added new 'type' tag (#682) * Update docs/TroubleShootingSteps.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update GitHub Issues link in troubleshooting steps --------- Co-authored-by: VishalS-Microsoft <v-vishshinde@microsoft.com> Co-authored-by: Harsh-Microsoft <v-hbangera@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: Removed commented params * Update README and azure.yml for minimum azd version 1.18.0 --------- Co-authored-by: NirajC-Microsoft <v-nirajcha@microsoft.com> Co-authored-by: VishalS-Microsoft <v-vishshinde@microsoft.com> Co-authored-by: Harsh-Microsoft <v-hbangera@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Prajwal D C <v-dcprajwal@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR focuses on infrastructure template clean-up by removing commented-out code parameters while also implementing several related improvements. The changes involve cleaning up the main Bicep template, updating configuration variables for better clarity, adding documentation, and enhancing deployment workflows.
- Removed commented-out parameters from
infra/main.bicep
to improve template maintainability - Refactored configuration variables for better naming consistency (MID_ID → SQL_MID_ID)
- Updated Azure Developer CLI version requirements to 1.18.0+ across multiple files
Reviewed Changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
infra/main.bicep | Removed commented parameters and added SQL-specific managed identity with proper role assignments |
src/App/backend/common/config.py | Added SQL_MID_ID configuration variable alongside existing MID_ID |
src/App/backend/services/sqldb_service.py | Updated to use new SQL_MID_ID configuration variable |
infra/scripts/process_sample_data.sh | Renamed variables for SQL managed identity operations |
infra/main.json | Updated template hash and deployment dependencies order |
tests/e2e-test/pages/homePage.py | Adjusted timeout values for chat history operations |
docs/ | Added ACR build guide and expanded troubleshooting documentation |
azure.yaml, README.md, docs/DeploymentGuide.md | Updated azd version requirement to 1.18.0+ |
.github/workflows/ | Updated template validation action and added deployment tags |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Disable the use of Dev Container for Azure template validation.
fix: Cross subscription issue while running post deployments scrip
🎉 This PR is included in version 1.9.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Purpose
This pull request introduces several improvements and updates related to deployment requirements, documentation, error troubleshooting, and workflow automation for the solution accelerator. The most notable changes include raising the minimum required version of the Azure Developer CLI (
azd
), expanding and clarifying troubleshooting documentation, updating workflow files for better validation and deployment metadata, and adding a new guide for building and pushing container images.Deployment Requirements & Documentation
azd
) to 1.18.0 inazure.yaml
,README.md
, anddocs/DeploymentGuide.md
, and added clear notes to documentation to ensure users install the correct version before deployment. [1] [2] [3] [4]docs/ACRBuildAndPushGuide.md
) for building and pushing Docker images to Azure Container Registry (ACR), including step-by-step instructions for both backend and frontend services, verification steps, and best practices.Troubleshooting Enhancements
docs/TroubleShootingSteps.md
) to cover many additional Azure deployment errors, their causes, and resolutions, including new sections for errors likeInvalidRequestContent
,ReadOnlyDisabledSubscription
,SkuNotAvailable
,CrossTenantDeploymentNotPermitted
,PrincipalNotFound
, and more. [1] [2] [3] [4]Workflow & Automation Updates
.github/workflows/azure-dev.yml
: Upgraded the Azure template validation action to v0.4.2, added explicit secrets, setuseDevContainer
to false, and improved workflow dispatch triggers..github/workflows/CAdeploy.yml
: Added a step to generate a deployment timestamp and included deployment metadata tags for improved resource tracking.Infrastructure Template Cleanup
infra/main.bicep
to clean up the infrastructure code and improve maintainability.These changes collectively improve the reliability, maintainability, and clarity of the deployment process and supporting documentation for the solution accelerator.
Deployment and Tooling Requirements
azd
) version to 1.18.0 or higher inazure.yaml
,README.md
, anddocs/DeploymentGuide.md
to ensure compatibility with deployment scripts and infrastructure templates. [1] [2] [3] [4].github/workflows/CAdeploy.yml
, added logic to generate a UTC timestamp for resource tagging and included new tags in Azure deployment parameters for better resource tracking and auditability.Documentation Enhancements
docs/ACRBuildAndPushGuide.md
) for building and pushing Docker images to Azure Container Registry (ACR), covering both backend and frontend services, manual image updates, and verification steps.Troubleshooting Improvements
docs/TroubleShootingSteps.md
with new error scenarios and resolutions, including errors related to request content, subscription status, SKU availability, cross-tenant deployments, policy restrictions, resource restoration, principal not found, storage redundancy, deployment not found, deployment cancellation, resource group deletion timeout, SQL server reference issues, Cosmos DB provisioning failures, OpenAI quota access, and container image build errors. [1] [2] [3] [4]Infrastructure Template Clean-up
fabricWorkspaceId
,AzureOpenAILocation
,vmAdminUsername
,vmAdminPassword
) frominfra/main.bicep
to improve maintainability and reduce confusion. [1] [2] [3]Minor Documentation Corrections
Let me know if you'd like to walk through any specific changes in detail!
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information