-
Notifications
You must be signed in to change notification settings - Fork 156
refactor: removed commented code, fixes for Standard Gallery validation & updated docs #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
fd1af72
fix: added tags in CAdeploy.yml file (#675)
VishalS-Microsoft 2fcaf2b
fix: Remove createdby from pipeline and add change Createdby logic in…
NirajC-Microsoft a6ced10
added new 'type' tag (#682)
VishalS-Microsoft b17a9c4
Merge branch 'main' into dev
Harsh-Microsoft 46671f7
Create new Managed Identity for SQL operations with least privileges
Vamshi-Microsoft 3db4137
Update docs/TroubleShootingSteps.md
NirajC-Microsoft c6f19ab
Update GitHub Issues link in troubleshooting steps
NirajC-Microsoft 4abbc6d
removed SQL user assigned identity from key vault and SQL DB module
Vamshi-Microsoft e3f2be4
Merge branch 'dev' into psl-sql-uami-least-privilege
Vamshi-Microsoft ad371b4
Refactor DNS zone naming and update SQL database redundancy settings
Vamshi-Microsoft d6a21f8
fix pylint issues
Vamshi-Microsoft 103420b
Merge pull request #688 from microsoft/psl-sql-uami-least-privilege
Vamshi-Microsoft 1b49c5d
refactor: Update README, azure.yml for minimum azd version 1.18.0 & r…
Vamshi-Microsoft e95aed3
Update Azure template validation action to latest version
Roopan-Microsoft 9258bc9
Update azure-dev.yml
Roopan-Microsoft 78b56a3
Update azure-dev.yml
Roopan-Microsoft 65cff53
Chore: Disable Dev Container usage in Azure validation step
Prajwal-Microsoft 36f0162
chore: Refactor Azure DevOps workflow configuration
Prajwal-Microsoft cdb0f7f
fix: Rename main.bicep for network module
Prajwal-Microsoft 7976ca9
chore: Update Azure template validation action version
Prajwal-Microsoft 431d908
chore: Add validateTests parameter to Azure Dev workflow
Prajwal-Microsoft fe67217
chore: Update Azure template validation action version
Prajwal-Microsoft 1df8876
fix post deployment script to support exp
Vamshi-Microsoft 1137a88
Merge pull request #693 from microsoft/psl-postdeploymentscript-exp
Prajwal-Microsoft 21e668e
refactor: Comments fixed
Prajwal-Microsoft b003fe1
Merge branch 'dev' of https://github.com/microsoft/Build-your-own-cop…
Prajwal-Microsoft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,94 @@ | ||
# Azure Container Registry (ACR) – Build & Push Guide | ||
|
||
This guide provides step-by-step instructions to build and push Docker images for **WebApp** and **Backend** services into Azure Container Registry (ACR). | ||
|
||
## 📋 Prerequisites | ||
Before starting, ensure you have: | ||
- An active [Azure Subscription](https://portal.azure.com/) | ||
- [Azure CLI](https://learn.microsoft.com/en-us/cli/azure/install-azure-cli) installed and logged in | ||
- [Docker Desktop](https://docs.docker.com/get-docker/) installed and running | ||
- Access to your Azure Container Registry (ACR) | ||
- To create an Azure Container Registry (ACR), you can refer to the following guides: | ||
|
||
- [Create Container Registry using Azure CLI](https://learn.microsoft.com/en-us/azure/container-registry/container-registry-get-started-azure-cli) | ||
|
||
- [Create Container Registry using Azure Portal](https://learn.microsoft.com/en-us/azure/container-registry/container-registry-get-started-portal?tabs=azure-cli) | ||
|
||
- [Create Container Registry using PowerShell](https://learn.microsoft.com/en-us/azure/container-registry/container-registry-get-started-powershell) | ||
|
||
- [Create Container Registry using ARM Template](https://learn.microsoft.com/en-us/azure/container-registry/container-registry-get-started-geo-replication-template) | ||
|
||
- [Create Container Registry using Bicep](https://learn.microsoft.com/en-us/azure/container-registry/container-registry-get-started-bicep?tabs=CLI) | ||
|
||
--- | ||
|
||
Login to ACR : | ||
``` bash | ||
az acr login --name $ACR_NAME | ||
``` | ||
|
||
## 🚀 Build and Push Images | ||
|
||
**Backend :** | ||
|
||
```bash | ||
az acr login --name <containerregname> | ||
docker build --no-cache -f docker/Backend.Dockerfile -t <acrloginserver>/<repo>:<tagname> . | ||
docker push <acrloginserver>/<repo>:<tagname> | ||
``` | ||
|
||
If you want to update image tag and image manually you can follow below steps: | ||
- Go to your **Container App** in the [Azure Portal](https://portal.azure.com/#home). | ||
- In the left menu, select **Containers**. | ||
- Under your container, update: | ||
|
||
- Image source → Azure Container Registry / Docker Hub. | ||
|
||
- Image name → myapp/backend. | ||
|
||
- Tag → change to the new one you pushed (e.g., v2). | ||
|
||
- Click **Save** → this will create a new revision automatically with the updated image. | ||
|
||
 | ||
|
||
**WebApp :** | ||
|
||
```bash | ||
az acr login --name <containerregname> | ||
docker build --no-cache -f docker/Frontend.Dockerfile -t <acrloginserver>/<repo>:<tagname> . | ||
docker push <acrloginserver>/<repo>:<tagname> | ||
``` | ||
|
||
If you want to update image tag and image manually you can follow below steps: | ||
- Go to your App Service in the [Azure Portal](https://portal.azure.com/#home). | ||
- In the left menu, select Deployment → Deployment Center | ||
- Under Container settings, you can configure: | ||
|
||
- Image Source → (e.g., Azure Container Registry / Docker Hub / Other). | ||
|
||
- Image Name → e.g., myapp/backend. | ||
|
||
- Tag → e.g., v1.2.3. | ||
|
||
 | ||
|
||
|
||
## ✅ Verification | ||
|
||
Run the following command to verify that images were pushed successfully: | ||
```bash | ||
az acr repository list --name $ACR_NAME --output table | ||
``` | ||
|
||
You should see repositories in the output. | ||
|
||
## 📝 Notes | ||
|
||
- Always use meaningful tags (v1.0.0, staging, prod) instead of just latest. | ||
|
||
- If you are pushing from a CI/CD pipeline, make sure the pipeline agent has access to Docker and ACR. | ||
|
||
- For private images, ensure your services (e.g., Azure Container Apps, AKS, App Service) are configured with appropriate ACR pull permissions. | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.