fix(drawer): overflow shadow only renders when scrollable is true #3210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: be0a62c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: 0 B Total Size: 1.59 MB
ℹ️ View Unchanged
|
tsck
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR fixes a bug in the Drawer component where the overflow shadow was being rendered even when the
scrollableprop was set tofalse. The fix ensures that the shadow indicator and the scroll intercept element are only rendered whenscrollable={true}, improving the visual consistency of the component when scrolling is disabled.The changes include:
hasShadowTopstyle only whenscrollableis truescrollableis trueskipparameter from theuseInViewhook to simplify the logic🎟️ Jira ticket: No associated ticket
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes
scrollable={false}propscrollable={true}prop