Skip to content

fix(drawer): overflow shadow only renders when scrollable is true #3210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2025
Merged

fix(drawer): overflow shadow only renders when scrollable is true #3210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d99aab
fix(drawer): overflow shadow only renders when scrollable is true
stephl3 Oct 11, 2025
be0a62c
chore(drawer): changeset
stephl3 Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/odd-kiwis-run.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@leafygreen-ui/drawer': patch
---

Fix `scrollable` prop so overflow shadow does not ever render if `scrollable={false}`
5 changes: 2 additions & 3 deletions packages/drawer/src/Drawer/Drawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ export const Drawer = forwardRef<HTMLDivElement, DrawerProps>(
const { ref: interceptRef, inView: isInterceptInView } = useInView({
initialInView: true,
fallbackInView: true,
skip: !scrollable,
});

const showCloseButton = !!onClose;
Expand Down Expand Up @@ -282,7 +281,7 @@ export const Drawer = forwardRef<HTMLDivElement, DrawerProps>(
</div>
<div
className={getChildrenContainerStyles({
hasShadowTop: !isInterceptInView,
hasShadowTop: scrollable && !isInterceptInView,
theme,
})}
>
Expand All @@ -296,7 +295,7 @@ export const Drawer = forwardRef<HTMLDivElement, DrawerProps>(
data-testid={lgIds.scrollContainer}
>
{/* Empty span element used to track if children container has scrolled down */}
<span ref={interceptRef} />
{scrollable && <span ref={interceptRef} />}
{children}
</div>
) : (
Expand Down
Loading