MONGOCRYPT-572 remove QE-V1 code and tests #934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mongocrypt_setopt_fle2v2` can only be called privately. It is only used in now-defunct tests of QEv1.
QEv2 does not append `deleteTokens`
Update payloads to V2 payloads. Remove `eccCollection`. The `eccCollection` is not used in QEv2.
v1 tests were converted to v2. v1 is no longer needed.
The `eccCollection` is unused in QEv2
Edges are sent for range payloads. Tested elsewhere. Redundant test is soon to be removed.
adriandole
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves MONGOCRYPT-572. Verified with this patch build.
Background & Motivation
MongoDB 7.0 dropped QE-V1 and added stable support of QE-V2 (SPM-2972). MONGOCRYPT-561 makes QE-V2 the default and prevents using QE-V1 with public API. This PR removes code for QE-V1 and updates tests. No behavior change is expected when using the public API. The removal is intended to ease implementation of MONGOCRYPT-723.
Tests explicitly decrypting each payload type are added. This is intended to serve as a reference and add missing test coverage for decrypting QE-V2 payloads.
The defunct
mongocrypt_setopt_fle2v2is removed.mongocrypt_setopt_fle2v2was private API only used in outdated tests of the QE-V1 protocol.Generating
deleteTokensis now removed.deleteTokensare not generated for QE-V2.References to the
eccCollectionin tests are removed. TheeccCollectionwas needed for QE-V1 but is not used in QE-V2 (SERVER-75683).Test payloads are updated from V1 to V2 as needed. dump_payload can be used to identify a payload:
This script was used to find and unused JSON test files. Unused test files were removed with one exception:
test/data/keys/12345678123498761234123456789014-local-document.jsonwas kept for consistency with other keys in thetest/data/keysdirectory.This PR notably does not remove the Range-V1 protocol. Removing RangeV1 is tracked in MONGOCRYPT-711.